[gnome-builder] search: disable progress bar in search results



commit 6903a246ec3cc3c273fa9325b8c504c69aadad7e
Author: Christian Hergert <christian hergert me>
Date:   Sat Sep 19 00:01:27 2015 -0700

    search: disable progress bar in search results
    
    We are disabling this for 3.18 because it isn't really that useful.
    I think we should rethink the value of "score" in the future, since they
    are not that useful except within the group they are in. And we already
    have that visually because they are sorted.

 data/ui/gb-search-display-row.ui   |    2 +-
 src/search/gb-search-display-row.c |   11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletions(-)
---
diff --git a/data/ui/gb-search-display-row.ui b/data/ui/gb-search-display-row.ui
index 2a2a240..fd81266 100644
--- a/data/ui/gb-search-display-row.ui
+++ b/data/ui/gb-search-display-row.ui
@@ -35,7 +35,7 @@
         <child>
           <object class="GtkProgressBar" id="progress">
             <property name="inverted">True</property>
-            <property name="visible">True</property>
+            <property name="visible">False</property>
             <property name="valign">center</property>
             <property name="margin_end">6</property>
             <style>
diff --git a/src/search/gb-search-display-row.c b/src/search/gb-search-display-row.c
index 9dfb1d2..47ce729 100644
--- a/src/search/gb-search-display-row.c
+++ b/src/search/gb-search-display-row.c
@@ -64,7 +64,18 @@ gb_search_display_row_connect (GbSearchDisplayRow *row,
 
   fraction = ide_search_result_get_score (result);
   gtk_progress_bar_set_fraction (row->progress, fraction);
+
+#if 0
+  /*
+   * XXX:
+   *
+   * We are disabling this for 3.18 because it isn't really that useful.
+   * I think we should rethink the value of "score" in the future, since they
+   * are not that useful except within the group they are in. And we already
+   * have that visually because they are sorted.
+   */
   gtk_widget_set_visible (GTK_WIDGET (row->progress), (fraction > 0.0));
+#endif
 }
 
 IdeSearchResult *


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]