[ostree] _ostree_static_delta_part_validate: Take a stream instead of a file as arg



commit fd6c572c42a061d61fc0367c8097cc0b5590294a
Author: Alexander Larsson <alexl redhat com>
Date:   Thu Sep 10 20:16:52 2015 +0200

    _ostree_static_delta_part_validate: Take a stream instead of a file as arg
    
    This is only called in one place, and we have already opened the file there,
    no need to open it twice.

 src/libostree/ostree-repo-static-delta-core.c      |    2 +-
 src/libostree/ostree-repo-static-delta-private.h   |    2 +-
 .../ostree-repo-static-delta-processing.c          |    9 ++-------
 3 files changed, 4 insertions(+), 9 deletions(-)
---
diff --git a/src/libostree/ostree-repo-static-delta-core.c b/src/libostree/ostree-repo-static-delta-core.c
index cd2940b..c58f868 100644
--- a/src/libostree/ostree-repo-static-delta-core.c
+++ b/src/libostree/ostree-repo-static-delta-core.c
@@ -318,7 +318,7 @@ ostree_repo_static_delta_execute_offline (OstreeRepo                    *self,
       if (!skip_validation)
         {
           g_autofree char *expected_checksum = ostree_checksum_from_bytes (csum);
-          if (!_ostree_static_delta_part_validate (self, part_path, i,
+          if (!_ostree_static_delta_part_validate (self, in, i,
                                                    expected_checksum,
                                                    cancellable, error))
             goto out;
diff --git a/src/libostree/ostree-repo-static-delta-private.h 
b/src/libostree/ostree-repo-static-delta-private.h
index 4df3b8c..7dfba0a 100644
--- a/src/libostree/ostree-repo-static-delta-private.h
+++ b/src/libostree/ostree-repo-static-delta-private.h
@@ -104,7 +104,7 @@ G_BEGIN_DECLS
 #define OSTREE_STATIC_DELTA_SUPERBLOCK_FORMAT "(a{sv}tayay" OSTREE_COMMIT_GVARIANT_STRING "aya" 
OSTREE_STATIC_DELTA_META_ENTRY_FORMAT "a" OSTREE_STATIC_DELTA_FALLBACK_FORMAT ")"
 
 gboolean _ostree_static_delta_part_validate (OstreeRepo     *repo,
-                                             GFile          *part_path,
+                                             GInputStream   *in,
                                              guint           part_offset,
                                              const char     *expected_checksum,
                                              GCancellable   *cancellable,
diff --git a/src/libostree/ostree-repo-static-delta-processing.c 
b/src/libostree/ostree-repo-static-delta-processing.c
index 1f2b326..18687f8 100644
--- a/src/libostree/ostree-repo-static-delta-processing.c
+++ b/src/libostree/ostree-repo-static-delta-processing.c
@@ -150,22 +150,17 @@ open_output_target (StaticDeltaExecutionState   *state,
 
 gboolean
 _ostree_static_delta_part_validate (OstreeRepo     *repo,
-                                    GFile          *part_path,
+                                    GInputStream   *in,
                                     guint           part_offset,
                                     const char     *expected_checksum,
                                     GCancellable   *cancellable,
                                     GError        **error)
 {
   gboolean ret = FALSE;
-  g_autoptr(GInputStream) tmp_in = NULL;
   g_autofree guchar *actual_checksum_bytes = NULL;
   g_autofree char *actual_checksum = NULL;
   
-  tmp_in = (GInputStream*)g_file_read (part_path, cancellable, error);
-  if (!tmp_in)
-    goto out;
-  
-  if (!ot_gio_checksum_stream (tmp_in, &actual_checksum_bytes,
+  if (!ot_gio_checksum_stream (in, &actual_checksum_bytes,
                                cancellable, error))
     goto out;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]