[gtk+] settings: Avoid a redundant check



commit 389ae3e0226533680acf67c6f62d3c3bdee1e4e2
Author: Matthias Clasen <mclasen redhat com>
Date:   Tue Sep 8 19:29:32 2015 -0400

    settings: Avoid a redundant check
    
    g_value_transform already returns whether it was successful
    or not, so no need to call g_value_type_transformable beforehand.

 gdk/x11/gdkscreen-x11.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
---
diff --git a/gdk/x11/gdkscreen-x11.c b/gdk/x11/gdkscreen-x11.c
index 8b2374e..44bb69f 100644
--- a/gdk/x11/gdkscreen-x11.c
+++ b/gdk/x11/gdkscreen-x11.c
@@ -1520,7 +1520,7 @@ gdk_x11_screen_get_setting (GdkScreen   *screen,
   if (setting == NULL)
     goto out;
 
-  if (!g_value_type_transformable (G_VALUE_TYPE (setting), G_VALUE_TYPE (value)))
+  if (!g_value_transform (setting, value))
     {
       g_warning ("Cannot transform xsetting %s of type %s to type %s\n",
                 name,
@@ -1529,8 +1529,6 @@ gdk_x11_screen_get_setting (GdkScreen   *screen,
       goto out;
     }
 
-  g_value_transform (setting, value);
-
   return TRUE;
 
  out:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]