[gnome-builder] editor: add GbEditorViewAddin::language_changed vfunc



commit b10e6ef5f8516bcfc83d4086a6b7c5efb20c0eb3
Author: Christian Hergert <christian hergert me>
Date:   Thu Sep 3 18:14:02 2015 -0700

    editor: add GbEditorViewAddin::language_changed vfunc
    
    This interface vfunc make simplifies the process for plugins to get
    notified when the active language has changed. Therefore, it is no
    longer necessary to bind to document signals to enable/disable some
    extension features.

 src/Makefile.am                           |    1 +
 src/editor/gb-editor-view-addin-private.h |   34 +++++++++++++++
 src/editor/gb-editor-view-addin.c         |   10 +++++
 src/editor/gb-editor-view-addin.h         |   15 +++----
 src/editor/gb-editor-view.c               |   63 ++++++++++++++++++++++++++++-
 5 files changed, 113 insertions(+), 10 deletions(-)
---
diff --git a/src/Makefile.am b/src/Makefile.am
index 81166e7..8ba0aa5 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -55,6 +55,7 @@ libgnome_builder_la_SOURCES = \
        editor/gb-editor-tweak-widget.h \
        editor/gb-editor-view-actions.c \
        editor/gb-editor-view-actions.h \
+       editor/gb-editor-view-addin-private.h \
        editor/gb-editor-view-private.h \
        greeter/gb-greeter-pill-box.c \
        greeter/gb-greeter-pill-box.h \
diff --git a/src/editor/gb-editor-view-addin-private.h b/src/editor/gb-editor-view-addin-private.h
new file mode 100644
index 0000000..8ac9394
--- /dev/null
+++ b/src/editor/gb-editor-view-addin-private.h
@@ -0,0 +1,34 @@
+/* gb-editor-view-addin-private.h
+ *
+ * Copyright (C) 2015 Christian Hergert <christian hergert me>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef GB_EDITOR_VIEW_ADDIN_PRIVATE_H
+#define GB_EDITOR_VIEW_ADDIN_PRIVATE_H
+
+#include "gb-editor-view-addin.h"
+
+G_BEGIN_DECLS
+
+void gb_editor_view_addin_language_changed (GbEditorViewAddin *self,
+                                            const gchar       *language_id);
+void gb_editor_view_addin_load             (GbEditorViewAddin *self,
+                                            GbEditorView      *view);
+void gb_editor_view_addin_unload           (GbEditorViewAddin *self,
+                                            GbEditorView      *view);
+G_END_DECLS
+
+#endif /* GB_EDITOR_VIEW_ADDIN_PRIVATE_H */
diff --git a/src/editor/gb-editor-view-addin.c b/src/editor/gb-editor-view-addin.c
index c4c2a36..172655f 100644
--- a/src/editor/gb-editor-view-addin.c
+++ b/src/editor/gb-editor-view-addin.c
@@ -52,3 +52,13 @@ gb_editor_view_addin_unload (GbEditorViewAddin *self,
 
   GB_EDITOR_VIEW_ADDIN_GET_IFACE (self)->unload (self, view);
 }
+
+void
+gb_editor_view_addin_language_changed (GbEditorViewAddin *self,
+                                       const gchar       *language_id)
+{
+  g_return_if_fail (GB_IS_EDITOR_VIEW_ADDIN (self));
+
+  if (GB_EDITOR_VIEW_ADDIN_GET_IFACE (self)->language_changed)
+    GB_EDITOR_VIEW_ADDIN_GET_IFACE (self)->language_changed (self, language_id);
+}
diff --git a/src/editor/gb-editor-view-addin.h b/src/editor/gb-editor-view-addin.h
index 04916e6..bb5717a 100644
--- a/src/editor/gb-editor-view-addin.h
+++ b/src/editor/gb-editor-view-addin.h
@@ -31,17 +31,14 @@ struct _GbEditorViewAddinInterface
 {
   GTypeInterface parent;
 
-  void (*load)   (GbEditorViewAddin *self,
-                  GbEditorView      *view);
-  void (*unload) (GbEditorViewAddin *self,
-                  GbEditorView      *view);
+  void (*load)             (GbEditorViewAddin *self,
+                            GbEditorView      *view);
+  void (*unload)           (GbEditorViewAddin *self,
+                            GbEditorView      *view);
+  void (*language_changed) (GbEditorViewAddin *self,
+                            const gchar       *language_id);
 };
 
-void gb_editor_view_addin_load   (GbEditorViewAddin *self,
-                                  GbEditorView      *view);
-void gb_editor_view_addin_unload (GbEditorViewAddin *self,
-                                  GbEditorView      *view);
-
 G_END_DECLS
 
 #endif /* GB_EDITOR_VIEW_ADDIN_H */
diff --git a/src/editor/gb-editor-view.c b/src/editor/gb-editor-view.c
index 6fee4d4..e0e2569 100644
--- a/src/editor/gb-editor-view.c
+++ b/src/editor/gb-editor-view.c
@@ -21,9 +21,10 @@
 #include <glib/gi18n.h>
 
 #include "gb-editor-frame-private.h"
-#include "gb-editor-view.h"
 #include "gb-editor-view-actions.h"
 #include "gb-editor-view-addin.h"
+#include "gb-editor-view.h"
+#include "gb-editor-view-addin-private.h"
 #include "gb-editor-view-private.h"
 #include "gb-widget.h"
 
@@ -213,6 +214,39 @@ gb_editor_view__buffer_notify_title (GbEditorView *self,
 }
 
 static void
+notify_language_foreach (PeasExtensionSet *set,
+                         PeasPluginInfo   *plugin_info,
+                         PeasExtension    *exten,
+                         gpointer          user_data)
+{
+  const gchar *language_id = user_data;
+
+  gb_editor_view_addin_language_changed (GB_EDITOR_VIEW_ADDIN (exten), language_id);
+}
+
+static void
+gb_editor_view__buffer_notify_language (GbEditorView     *self,
+                                        GParamSpec       *pspec,
+                                        GbEditorDocument *document)
+{
+  g_assert (GB_IS_EDITOR_VIEW (self));
+  g_assert (GB_IS_EDITOR_DOCUMENT (document));
+
+  if (self->extensions != NULL)
+    {
+      GtkSourceLanguage *language;
+      const gchar *language_id;
+
+      language = gtk_source_buffer_get_language (GTK_SOURCE_BUFFER (document));
+      language_id = language ? gtk_source_language_get_id (language) : NULL;
+
+      peas_extension_set_foreach (self->extensions,
+                                  notify_language_foreach,
+                                  (gchar *)language_id);
+    }
+}
+
+static void
 gb_editor_view_set_document (GbEditorView     *self,
                              GbEditorDocument *document)
 {
@@ -251,6 +285,12 @@ gb_editor_view_set_document (GbEditorView     *self,
                                G_CONNECT_SWAPPED);
 
       g_signal_connect_object (document,
+                               "notify::language",
+                               G_CALLBACK (gb_editor_view__buffer_notify_language),
+                               self,
+                               G_CONNECT_SWAPPED);
+
+      g_signal_connect_object (document,
                                "notify::changed-on-volume",
                                G_CALLBACK (gb_editor_view__buffer_changed_on_volume),
                                self,
@@ -258,6 +298,8 @@ gb_editor_view_set_document (GbEditorView     *self,
 
       g_object_notify_by_pspec (G_OBJECT (self), gParamSpecs [PROP_DOCUMENT]);
 
+      gb_editor_view__buffer_notify_language (self, NULL, document);
+
       gb_editor_view_actions_update (self);
     }
 }
@@ -379,12 +421,31 @@ gb_editor_view__extension_added (PeasExtensionSet  *set,
                                  GbEditorViewAddin *addin,
                                  GbEditorView      *self)
 {
+  GbDocument *document;
+
   g_assert (PEAS_IS_EXTENSION_SET (set));
   g_assert (info != NULL);
   g_assert (GB_IS_EDITOR_VIEW_ADDIN (addin));
   g_assert (GB_IS_EDITOR_VIEW (self));
 
   gb_editor_view_addin_load (addin, self);
+
+  document = gb_view_get_document (GB_VIEW (self));
+
+  if (document != NULL)
+    {
+      GtkSourceLanguage *language;
+
+      language = gtk_source_buffer_get_language (GTK_SOURCE_BUFFER (document));
+
+      if (language != NULL)
+        {
+          const gchar *language_id;
+
+          language_id = gtk_source_language_get_id (language);
+          gb_editor_view_addin_language_changed (addin, language_id);
+        }
+    }
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]