[ostree] init-fs: Explicitly set /tmp to 01777
- From: Colin Walters <walters src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [ostree] init-fs: Explicitly set /tmp to 01777
- Date: Fri, 30 Oct 2015 21:11:48 +0000 (UTC)
commit 7bf138b0364c8922da108e81a649bef1a5ad212b
Author: Colin Walters <walters verbum org>
Date: Fri Oct 30 17:10:23 2015 -0400
init-fs: Explicitly set /tmp to 01777
I think most people were using tmpfs-on-tmp and so didn't hit this.
See https://bugzilla.redhat.com/show_bug.cgi?id=1276775
src/ostree/ot-admin-builtin-init-fs.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
---
diff --git a/src/ostree/ot-admin-builtin-init-fs.c b/src/ostree/ot-admin-builtin-init-fs.c
index 71b3b55..0172f01 100644
--- a/src/ostree/ot-admin-builtin-init-fs.c
+++ b/src/ostree/ot-admin-builtin-init-fs.c
@@ -77,6 +77,16 @@ ot_admin_builtin_init_fs (int argc, char **argv, GCancellable *cancellable, GErr
child = g_file_get_child (dir, "tmp");
if (!gs_file_ensure_directory_mode (child, 01777, cancellable, error))
goto out;
+ /* FIXME - we should be using an API that explicitly ignores umask;
+ */
+ {
+ const char *path = gs_file_get_path_cached (child);
+ if (chmod (path, 01777) == -1)
+ {
+ gs_set_prefix_error_from_errno (error, errno, "chmod");
+ goto out;
+ }
+ }
g_clear_object (&child);
if (!ostree_sysroot_ensure_initialized (target_sysroot, cancellable, error))
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]