[gimp/blend-tool-fun: 79/163] app: fix if() logic in gimp_plug_in_procedure_handle_return_values()



commit eb4ef6d38ff759b2d5b8cbaa3a77799b674338e3
Author: Michael Natterer <mitch gimp org>
Date:   Sun Sep 27 13:40:57 2015 +0200

    app: fix if() logic in gimp_plug_in_procedure_handle_return_values()
    
    if (! x > 0) is not the same as if (! (x > 0)) and beyond that it's
    much less stupid to write if (x == 0)...

 app/plug-in/gimppluginprocedure.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/app/plug-in/gimppluginprocedure.c b/app/plug-in/gimppluginprocedure.c
index 917742b..c750e53 100644
--- a/app/plug-in/gimppluginprocedure.c
+++ b/app/plug-in/gimppluginprocedure.c
@@ -974,7 +974,7 @@ gimp_plug_in_procedure_handle_return_values (GimpPlugInProcedure *proc,
   g_return_if_fail (GIMP_IS_PLUG_IN_PROCEDURE (proc));
   g_return_if_fail (return_vals != NULL);
 
-  if (! gimp_value_array_length (return_vals) > 0 ||
+  if (gimp_value_array_length (return_vals) == 0 ||
       G_VALUE_TYPE (gimp_value_array_index (return_vals, 0)) !=
       GIMP_TYPE_PDB_STATUS_TYPE)
     {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]