[gnome-nibbles] Add a couple FIXMEs
- From: Iulian Radu <iulianradu src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-nibbles] Add a couple FIXMEs
- Date: Mon, 26 Oct 2015 00:24:08 +0000 (UTC)
commit 1d81296e7aa416b29b667f89757904c5b6c751a1
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Sun Sep 20 12:33:46 2015 -0500
Add a couple FIXMEs
src/gnome-nibbles.vala | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
---
diff --git a/src/gnome-nibbles.vala b/src/gnome-nibbles.vala
index 27004b8..3f8e29e 100644
--- a/src/gnome-nibbles.vala
+++ b/src/gnome-nibbles.vala
@@ -592,6 +592,13 @@ public class Nibbles : Gtk.Application
private void log_score_cb (int score)
{
+ // FIXME: Need a better end game experience if we return early here.
+ // Leaving the player with a blank screen is not good. Make sure the
+ // new game and pause buttons do something sane (e.g. pause should be
+ // insensitive; new game should start a new game on level one and not
+ // trigger the scores dialog to be opened if the high scores table is
+ // not yet filled....)
+
if (game.numhumans != 1)
return;
@@ -605,6 +612,7 @@ public class Nibbles : Gtk.Application
try
{
if (scores_context.add_score.end (result))
+ // FIXME: Need a better end game experience here too. Same warnings apply.
return;
}
catch (GLib.Error e)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]