[gxml] Added unit tests for SerializableDouble
- From: Daniel Espinosa Ortiz <despinosa src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gxml] Added unit tests for SerializableDouble
- Date: Thu, 22 Oct 2015 00:44:02 +0000 (UTC)
commit 3d4a99b5952091b96a2a47b3e15b0337c9d364f4
Author: Daniel Espinosa <esodan gmail com>
Date: Wed Oct 21 19:42:26 2015 -0500
Added unit tests for SerializableDouble
* Fixed implementation for deserialize, the given value is taken as is
no parsing is done at all
gxml/SerializableDouble.vala | 7 +------
test/SerializablePropertyDoubleTest.vala | 16 ++++++++++++++++
2 files changed, 17 insertions(+), 6 deletions(-)
---
diff --git a/gxml/SerializableDouble.vala b/gxml/SerializableDouble.vala
index bd4710a..c777879 100644
--- a/gxml/SerializableDouble.vala
+++ b/gxml/SerializableDouble.vala
@@ -38,12 +38,7 @@ public class GXml.SerializableDouble : SerializableObjectModel, SerializableProp
public double get_value () { return double.parse (_val); }
public void set_value (double val) { _val = val.to_string (); }
public string get_serializable_property_value () { return _val; }
- public void set_serializable_property_value (string? val) {
- if (val == null)
- _val = val;
- else
- _val = double.parse (val).to_string ();
- }
+ public void set_serializable_property_value (string? val) { _val = val; }
public override string to_string () {
if (_val != null) return (double.parse (_val)).to_string ();
return "";
diff --git a/test/SerializablePropertyDoubleTest.vala b/test/SerializablePropertyDoubleTest.vala
index 0626153..2622594 100644
--- a/test/SerializablePropertyDoubleTest.vala
+++ b/test/SerializablePropertyDoubleTest.vala
@@ -103,5 +103,21 @@ class SerializablePropertyDoubleTest : GXmlTest {
assert_not_reached ();
}
});
+ Test.add_func ("/gxml/serializable/Double/deserialize",
+ () => {
+ try {
+ var doc1 = new xDocument.from_string ("""<?xml version="1.0"?>
+ <DoubleNode DoubleValue="3.1416"/>""");
+ var d = new DoubleNode ();
+ d.deserialize (doc1);
+ Test.message ("Actual value: "+d.double_value.get_serializable_property_value ());
+ assert (d.double_value.get_serializable_property_value () == "3.1416");
+ Test.message ("Actual value parse: "+"%2.4f".printf (double.parse
(d.double_value.get_serializable_property_value ())));
+ assert ("%2.4f".printf (double.parse (d.double_value.get_serializable_property_value ())) ==
"3.1416");
+ } catch (GLib.Error e) {
+ Test.message (@"ERROR: $(e.message)");
+ assert_not_reached ();
+ }
+ });
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]