[gnome-control-center] shell: Fix leak in cc_shell_item_view_update_cells



commit 3b5e7e180561dfdded8e7615f957273ac051551d
Author: Christophe Fergeau <cfergeau redhat com>
Date:   Wed Jul 29 10:58:38 2015 +0200

    shell: Fix leak in cc_shell_item_view_update_cells
    
    ==11430== 48 (24 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 10,663 of 18,7
    ==11430==    at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==11430==    by 0x7F260AC: g_malloc (gmem.c:97)
    ==11430==    by 0x7F3F0F7: g_slice_alloc (gslice.c:1007)
    ==11430==    by 0x7F19BE5: g_list_prepend (glist.c:311)
    ==11430==    by 0x684843B: accum_cells (gtkcellarea.c:1563)
    ==11430==    by 0x6850989: gtk_cell_area_box_foreach (gtkcellareabox.c:1145)
    ==11430==    by 0x6848AAA: gtk_cell_area_foreach (gtkcellarea.c:1730)
    ==11430==    by 0x6848490: gtk_cell_area_get_cells (gtkcellarea.c:1573)
    ==11430==    by 0x6857339: gtk_cell_layout_get_cells (gtkcelllayout.c:592)
    ==11430==    by 0x685668F: gtk_cell_layout_default_get_cells (gtkcelllayout.c:342)
    ==11430==    by 0x6857339: gtk_cell_layout_get_cells (gtkcelllayout.c:592)
    ==11430==    by 0x45242B: cc_shell_item_view_update_cells (cc-shell-item-view.c:116)
    ==11430==    by 0x451DDD: cc_shell_category_view_constructed (cc-shell-category-view.c:141)
    ==11430==    by 0x7C8DC10: g_object_new_internal (gobject.c:1814)
    ==11430==    by 0x7C8E71A: g_object_new_valist (gobject.c:2033)
    ==11430==    by 0x7C8D6C5: g_object_new (gobject.c:1617)
    ==11430==    by 0x4520AB: cc_shell_category_view_new (cc-shell-category-view.c:213)
    ==11430==    by 0x44F5D2: add_category_view (cc-window.c:852)
    ==11430==    by 0x44F78B: setup_model (cc-window.c:880)
    ==11430==    by 0x450EBC: create_main_page (cc-window.c:1460)
    ==11430==    by 0x4514F1: create_window (cc-window.c:1553)
    ==11430==    by 0x45170A: cc_window_init (cc-window.c:1587)
    ==11430==    by 0x7CA6E7D: g_type_create_instance (gtype.c:1870)
    ==11430==    by 0x7C8DAC5: g_object_new_internal (gobject.c:1774)
    ==11430==    by 0x7C8E71A: g_object_new_valist (gobject.c:2033)
    ==11430==    by 0x7C8D6C5: g_object_new (gobject.c:1617)
    ==11430==    by 0x451847: cc_window_new (cc-window.c:1602)
    ==11430==    by 0x44D409: cc_application_startup (cc-application.c:262)
    ==11430==    by 0x7C8827D: g_cclosure_marshal_VOID__VOIDv (gmarshal.c:905)
    ==11430==    by 0x7C8590F: g_type_class_meta_marshalv (gclosure.c:1021)
    ==11430==    by 0x7C854D1: _g_closure_invoke_va (gclosure.c:864)
    ==11430==    by 0x7CA0771: g_signal_emit_valist (gsignal.c:3246)
    ==11430==    by 0x7CA18E9: g_signal_emit (gsignal.c:3393)
    ==11430==    by 0x7982671: g_application_register (gapplication.c:2015)
    ==11430==    by 0x79808D2: g_application_real_local_command_line (gapplication.c:983)
    ==11430==    by 0x68143D6: gtk_application_local_command_line (gtkapplication.c:638)
    ==11430==    by 0x7982D4D: g_application_run (gapplication.c:2280)
    ==11430==    by 0x44C96B: main (main.c:57)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756762

 shell/cc-shell-item-view.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/shell/cc-shell-item-view.c b/shell/cc-shell-item-view.c
index 42a31d7..bd1aeb7 100644
--- a/shell/cc-shell-item-view.c
+++ b/shell/cc-shell-item-view.c
@@ -126,6 +126,7 @@ cc_shell_item_view_update_cells (CcShellItemView *view)
                        break;
                }
        }
+       g_list_free (cells);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]