[glib-networking/wip/openssl] certificate: fix mem leak



commit 9153b7da5abe0dbe82c4c4dd1df3417ebc82b527
Author: Ignacio Casal Quinteiro <icq gnome org>
Date:   Fri Oct 16 15:33:14 2015 +0200

    certificate: fix mem leak

 tls/openssl/gtlscertificate-openssl.c |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)
---
diff --git a/tls/openssl/gtlscertificate-openssl.c b/tls/openssl/gtlscertificate-openssl.c
index c84e86e..99037e8 100644
--- a/tls/openssl/gtlscertificate-openssl.c
+++ b/tls/openssl/gtlscertificate-openssl.c
@@ -311,6 +311,14 @@ g_tls_certificate_openssl_verify (GTlsCertificate     *cert,
 
       store = X509_STORE_new ();
 
+      if (!X509_STORE_CTX_init (&csc, store, x, untrusted))
+        {
+          sk_X509_free (untrusted);
+          X509_STORE_CTX_cleanup (&csc);
+          X509_STORE_free (store);
+          return G_TLS_CERTIFICATE_GENERIC_ERROR;
+        }
+
       trusted = sk_X509_new_null ();
       cert_openssl = G_TLS_CERTIFICATE_OPENSSL (trusted_ca);
       for (; cert_openssl; cert_openssl = priv->issuer)
@@ -319,17 +327,11 @@ g_tls_certificate_openssl_verify (GTlsCertificate     *cert,
           sk_X509_push (trusted, priv->cert);
         }
 
-      if (!X509_STORE_CTX_init (&csc, store, x, untrusted))
-        {
-          X509_STORE_CTX_cleanup (&csc);
-          X509_STORE_free (store);
-          return G_TLS_CERTIFICATE_GENERIC_ERROR;
-        }
-
       X509_STORE_CTX_trusted_stack (&csc, trusted);
       if (X509_verify_cert (&csc) <= 0)
         gtls_flags |= g_tls_certificate_openssl_convert_error (X509_STORE_CTX_get_error (&csc));
 
+      sk_X509_free (trusted);
       X509_STORE_CTX_cleanup (&csc);
       X509_STORE_free (store);
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]