[gnome-builder/gnome-builder-3-18] symbol-tree: be assertive about parameters in filter callback



commit 44b49d3659dfc1b81974b546b3e0e69e8b1385bd
Author: Christian Hergert <chergert redhat com>
Date:   Wed Oct 14 15:27:50 2015 -0700

    symbol-tree: be assertive about parameters in filter callback
    
    These get compiled out of production builds, but are useful to catch more
    issues during development.

 plugins/symbol-tree/symbol-tree.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)
---
diff --git a/plugins/symbol-tree/symbol-tree.c b/plugins/symbol-tree/symbol-tree.c
index d80c58f..6680381 100644
--- a/plugins/symbol-tree/symbol-tree.c
+++ b/plugins/symbol-tree/symbol-tree.c
@@ -295,8 +295,16 @@ filter_symbols_cb (GbTree     *tree,
                    gpointer    user_data)
 {
   IdePatternSpec *spec = user_data;
+  const gchar *text;
+
+  g_assert (GB_IS_TREE (tree));
+  g_assert (GB_IS_TREE_NODE (node));
+  g_assert (spec != NULL);
+
+  if ((text = gb_tree_node_get_text (node)) != NULL)
+    return ide_pattern_spec_match (spec, text);
 
-  return ide_pattern_spec_match (spec, gb_tree_node_get_text (node));
+  return NULL;
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]