[gxml] SerializableValueList constructor requires property name
- From: Daniel Espinosa Ortiz <despinosa src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gxml] SerializableValueList constructor requires property name
- Date: Tue, 13 Oct 2015 21:22:16 +0000 (UTC)
commit 5c1d30418ad6a567a8c428349dfa0abf1795f6f8
Author: Daniel Espinosa <esodan gmail com>
Date: Tue Oct 6 16:54:34 2015 -0500
SerializableValueList constructor requires property name
gxml/SerializableValueList.vala | 2 +-
test/SerializablePropertyValueListTest.vala | 11 +++++------
2 files changed, 6 insertions(+), 7 deletions(-)
---
diff --git a/gxml/SerializableValueList.vala b/gxml/SerializableValueList.vala
index 16be42b..86082f2 100644
--- a/gxml/SerializableValueList.vala
+++ b/gxml/SerializableValueList.vala
@@ -33,7 +33,7 @@ public class GXml.SerializableValueList : SerializableObjectModel, SerializableP
private string _val = null;
private string _name = null;
private ArrayList<string> _values = null;
- public SerializableValueList.with_name (string name) { _name = name; }
+ public SerializableValueList (string name) { _name = name; }
public void add_values (string[] vals)
{
if (_values == null) _values = new ArrayList<string> ();
diff --git a/test/SerializablePropertyValueListTest.vala b/test/SerializablePropertyValueListTest.vala
index a5f8bec..21a6d3a 100644
--- a/test/SerializablePropertyValueListTest.vala
+++ b/test/SerializablePropertyValueListTest.vala
@@ -27,7 +27,7 @@ using GXml;
class SerializablePropertyValueListTest : GXmlTest {
public class ValueList : SerializableObjectModel
{
- public SerializableValueList values { get; set; }
+ public SerializableValueList values { get; set; default = new SerializableValueList ("values"); }
public int integer { get; set; default = 0; }
public string name { get; set; }
public override string node_name () { return "ValueList"; }
@@ -57,12 +57,11 @@ class SerializablePropertyValueListTest : GXmlTest {
() => {
try {
var vl = new ValueList ();
- vl.values = new SerializableValueList.with_name ("option");
var doc1 = new xDocument ();
vl.serialize (doc1);
Test.message ("XML1:\n"+doc1.to_string ());
var element1 = doc1.document_element;
- var evl1 = element1.get_attribute_node ("option");
+ var evl1 = element1.get_attribute_node ("values");
assert (evl1 == null);
var s1 = element1.get_attribute_node ("name");
assert (s1 == null);
@@ -80,7 +79,7 @@ class SerializablePropertyValueListTest : GXmlTest {
vl.serialize (doc2);
Test.message ("XML2:\n"+doc2.to_string ());
var element2 = doc2.document_element;
- var evl2 = element2.get_attribute_node ("option");
+ var evl2 = element2.get_attribute_node ("values");
assert (evl2 == null);
// Select a value
vl.values.select_value_at (1);
@@ -90,7 +89,7 @@ class SerializablePropertyValueListTest : GXmlTest {
vl.serialize (doc3);
Test.message ("XML3:\n"+doc3.to_string ());
var element3 = doc3.document_element;
- var evl3 = element3.get_attribute_node ("option");
+ var evl3 = element3.get_attribute_node ("values");
assert (evl3 != null);
assert (evl3.value == "Temp2");
// Set value to null/ignore
@@ -99,7 +98,7 @@ class SerializablePropertyValueListTest : GXmlTest {
vl.serialize (doc4);
Test.message ("XML4:\n"+doc4.to_string ());
var element4 = doc4.document_element;
- var evl4 = element4.get_attribute_node ("option");
+ var evl4 = element4.get_attribute_node ("values");
assert (evl4 == null);
} catch (GLib.Error e) {
Test.message (@"ERROR: $(e.message)");
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]