[network-manager-fortisslvpn] service: fix the error status handling
- From: Lubomir Rintel <lkundrak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-fortisslvpn] service: fix the error status handling
- Date: Tue, 13 Oct 2015 18:10:57 +0000 (UTC)
commit 7b7ffca2ec9443878dd8a86fa168484fec2b23e7
Author: Lubomir Rintel <lkundrak v3 sk>
Date: Tue Oct 13 20:05:22 2015 +0200
service: fix the error status handling
This has been copied from pptp but makes no sense for openfortivpn.
src/nm-fortisslvpn-service.c | 23 ++++-------------------
1 files changed, 4 insertions(+), 19 deletions(-)
---
diff --git a/src/nm-fortisslvpn-service.c b/src/nm-fortisslvpn-service.c
index 02e53f2..ffe6da4 100644
--- a/src/nm-fortisslvpn-service.c
+++ b/src/nm-fortisslvpn-service.c
@@ -619,27 +619,12 @@ openfortivpn_watch_cb (GPid pid, gint status, gpointer user_data)
waitpid (priv->pid, NULL, WNOHANG);
priv->pid = 0;
- /* Must be after data->state is set since signals use data->state */
- switch (error) {
- case 16:
- /* hangup */
- // FIXME: better failure reason
- nm_vpn_service_plugin_failure (NM_VPN_SERVICE_PLUGIN (plugin),
NM_VPN_PLUGIN_FAILURE_CONNECT_FAILED);
- break;
- case 2:
- /* Couldn't log in due to bad user/pass */
- nm_vpn_service_plugin_failure (NM_VPN_SERVICE_PLUGIN (plugin),
NM_VPN_PLUGIN_FAILURE_LOGIN_FAILED);
- break;
- case 1:
- /* Other error (couldn't bind to address, etc) */
- nm_vpn_service_plugin_failure (NM_VPN_SERVICE_PLUGIN (plugin),
NM_VPN_PLUGIN_FAILURE_CONNECT_FAILED);
- break;
- default:
- break;
- }
+ /* TODO: Better error indication from openfortivpn. */
+ if (error)
+ nm_vpn_service_plugin_failure (NM_VPN_SERVICE_PLUGIN (plugin),
+ NM_VPN_PLUGIN_FAILURE_CONNECT_FAILED);
nm_vpn_service_plugin_set_state (NM_VPN_SERVICE_PLUGIN (plugin), NM_VPN_SERVICE_STATE_STOPPED);
- cleanup_plugin (plugin);
}
static const char *
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]