[devhelp/wip/swilmet/various-code-improvements: 2/2] sidebar: various code improvements

[Sébastien Wilmet <swilmet src gnome org>]

commit bd223016d85f560a844d155a0ab0d6e85153947b
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sat Oct 10 10:33:30 2015 +0200

    sidebar: various code improvements
    
    Don't use strcmp() to compare if a string is empty.

 src/dh-sidebar.c |   15 ++++++++-------
 1 files changed, 8 insertions(+), 7 deletions(-)
---
diff --git a/src/dh-sidebar.c b/src/dh-sidebar.c
index dddb4c8..faa4dc3 100644
--- a/src/dh-sidebar.c
+++ b/src/dh-sidebar.c
@@ -278,17 +278,18 @@ sidebar_entry_changed_cb (GtkEntry  *entry,
                           DhSidebar *sidebar)
 {
         DhSidebarPrivate *priv = dh_sidebar_get_instance_private (sidebar);
+        const gchar *text;
 
-        /* If search entry is empty, hide the hitlist */
-        if (strcmp (gtk_entry_get_text (entry), "") == 0) {
+        text = gtk_entry_get_text (entry);
+
+        if (text == NULL || text[0] == '\0') {
                 gtk_widget_hide (GTK_WIDGET (priv->sw_hitlist));
                 gtk_widget_show (GTK_WIDGET (priv->sw_book_tree));
-                return;
+        } else {
+                gtk_widget_hide (GTK_WIDGET (priv->sw_book_tree));
+                gtk_widget_show (GTK_WIDGET (priv->sw_hitlist));
+                sidebar_search_run_idle (sidebar);
         }
-
-        gtk_widget_hide (GTK_WIDGET (priv->sw_book_tree));
-        gtk_widget_show (GTK_WIDGET (priv->sw_hitlist));
-        sidebar_search_run_idle (sidebar);
 }
 
 static gboolean