[gnome-commander/googletest] Adds iv_viewerwidget tests to googletest framework

[Uwe Scholz <uwescholz src gnome org>]

commit 8044ba57231e0e0100db123e038b508012dbe018
Author: Uwe Scholz <uwescholz src gnome org>
Date:   Tue Nov 24 19:52:05 2015 +0100

    Adds iv_viewerwidget tests to googletest framework

 tests/Makefile.am             |    2 +-
 tests/iv_viewerwidget_test.cc |  276 +++++++++++++++++++----------------------
 2 files changed, 130 insertions(+), 148 deletions(-)
---
diff --git a/tests/Makefile.am b/tests/Makefile.am
index bbbdec3..b359042 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -55,7 +55,7 @@ iv_textrenderer_SOURCES = iv_textrenderer_test.cc
 iv_textrenderer_CXXFLAGS = $(INTVLIBS)
 iv_textrenderer_LDFLAGS = $(INTVLIBS) -lgtest
 
-iv_viewerwidget_SOURCES = iv_viewerwidget_test.cc
+iv_viewerwidget_SOURCES = iv_viewerwidget_test.cc gcmd_tests_main.cc
 iv_viewerwidget_CXXFLAGS = $(INTVLIBS)
 iv_viewerwidget_LDFLAGS = $(INTVLIBS) -lgtest
 
diff --git a/tests/iv_viewerwidget_test.cc b/tests/iv_viewerwidget_test.cc
index 32ad542..085a357 100644
--- a/tests/iv_viewerwidget_test.cc
+++ b/tests/iv_viewerwidget_test.cc
@@ -1,177 +1,159 @@
-/*
-  GNOME Commander - A GNOME based file manager
-  Copyright (C) 2001-2006 Marcus Bjurman
-  Copyright (C) 2007-2012 Piotr Eljasiak
-    Copyright (C) 2013-2015 Uwe Scholz
+/**
+ * @file iv_viewerwidget_test.cc
+ * @brief Part of GNOME Commander - A GNOME based file manager
+ *
+ * @copyright (C) 2006 Assaf Gordon\n
+ * @copyright (C) 2007-2012 Piotr Eljasiak\n
+ * @copyright (C) 2013-2015 Uwe Scholz\n
+ *
+ * @details This module tests gviewer widget setter functions in libgviewer.
+ * @li Enconding: ASCII, UTF8, CP437, CP1251
+ * @li Display Mode: Text, Binary, Hex, Image
+ * @li Wrapping: TRUE, FALSE
+ * @li Fixed_limit: Sets number of Bytes per line
+ * @li Tab size: Set number of space per TAB character
+ * @li Scale: Sets scaling factor (0.1 to 3.0) in image mode
+ *
+ * @copyright This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * @copyright This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * @copyright You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+
+#include "gtest/gtest.h"
+#include <intviewer/libgviewer.h>
+
+const gchar *filename = "../INSTALL";
 
-  This program is free software; you can redistribute it and/or modify
-  it under the terms of the GNU General Public License as published by
-  the Free Software Foundation; either version 2 of the License, or
-  (at your option) any later version.
+////////////////////////////////////////////////////////////////////////
 
-  This program is distributed in the hope that it will be useful,
-  but WITHOUT ANY WARRANTY; without even the implied warranty of
-  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-  GNU General Public License for more details.
+class ViewerWidgetDisplayModeTest : public ::testing::TestWithParam<VIEWERDISPLAYMODE> {};
 
-  You should have received a copy of the GNU General Public License
-  along with this program; if not, write to the Free Software
-  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
+INSTANTIATE_TEST_CASE_P(InstantiationScaleFactor,
+                        ViewerWidgetDisplayModeTest,
+                        ::testing::Values(DISP_MODE_TEXT_FIXED,
+                                          DISP_MODE_BINARY,
+                                          DISP_MODE_HEXDUMP,
+                                          DISP_MODE_IMAGE));
 
-   Author: Assaf Gordon  <agordon88 gmail com>
-*/
+TEST_P(ViewerWidgetDisplayModeTest, gviewer_set_display_mode_test)
+{
+    GtkWidget *viewer;
+    viewer = gviewer_new();
+    gviewer_load_file(GVIEWER(viewer), filename);
+    gviewer_set_display_mode(GVIEWER(viewer),GetParam());
+    ASSERT_EQ(GetParam(), gviewer_get_display_mode(GVIEWER(viewer)));
+}
 
-#include <glib.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <unistd.h>
+////////////////////////////////////////////////////////////////////////
 
-#include <glib.h>
-#include <gtk/gtk.h>
+class ViewerWidgetTabSizeTest : public ::testing::TestWithParam<int> {};
 
-#include <intviewer/libgviewer.h>
+INSTANTIATE_TEST_CASE_P(InstantiationScaleFactor,
+                        ViewerWidgetTabSizeTest,
+                        ::testing::Range(1,10)); //TODO: Add test for x <= 0
 
-static gchar *filename = NULL;
-static gchar *encoding = NULL;
-static VIEWERDISPLAYMODE dispmode = DISP_MODE_TEXT_FIXED;
-static guint tab_size;
-static guint fixed_limit;
-static gboolean wrap_mode;
-static gboolean best_fit = TRUE;
-static double scale_factor = 1.0;
-static gboolean auto_detect_display_mode = TRUE;
-
-void usage()
+TEST_P(ViewerWidgetTabSizeTest, gviewer_set_tab_size_test)
 {
-    fprintf(stderr,"This program tests the gviewer widget in 'libgviewer'.\n\n");
-
-    fprintf(stderr,"Usage: test-textrenderer [-e encoding] [-d dispmode] [-w] [-f fixed_limit] [-t tab_size] 
[-s scale] filename\n\n");
-
-    fprintf(stderr,"\t-e enconding: ASCII, UTF8, CP437, CP1251, etc\n");
-    fprintf(stderr,"\t-d Display Mode:\n\t     auto(default)\n\t     Text\n\t     Binary\n\t     Hex\n\t     
 Image\n");
-    fprintf(stderr,"\t-w In fixed/variable text displays, turns on wrapping.\n");
-    fprintf(stderr,"\t-f fixed_limit: In Binary display mode, sets number of Bytes per line.\n");
-    fprintf(stderr,"\t-t tab size: In fixed/variable text displays, set number of space per TAB 
character.\n");
-    fprintf(stderr,"\t-s scale: In Image mode, use fixed scaling factor (0.1 to 3.0)\n\t\t(Default is using 
best-fit-to-window)\n");
-    fprintf(stderr,"\tfilename: The file to display.\n");
-    exit(0);
+    GtkWidget *viewer;
+    viewer = gviewer_new();
+    gviewer_load_file(GVIEWER(viewer), filename);
+    gviewer_set_tab_size(GVIEWER(viewer),GetParam());
+    ASSERT_EQ(GetParam(), gviewer_get_tab_size(GVIEWER(viewer)));
 }
 
-void parse_command_line(int argc, char *argv[])
+//////////////////////////////////////////////////////////////////////////
+
+class ViewerWidgetFixedLimitTest : public ::testing::TestWithParam<int> {};
+
+INSTANTIATE_TEST_CASE_P(InstantiationScaleFactor,
+                        ViewerWidgetFixedLimitTest,
+                        ::testing::Range(1,10)); //TODO: Add test for x <= 0
+
+TEST_P(ViewerWidgetFixedLimitTest, gviewer_set_fixed_limit_test)
 {
-    extern char *optarg;
-    extern int optind, opterr, optopt;
-    int c;
-
-    tab_size = 8;
-    fixed_limit = 40;
-    dispmode = DISP_MODE_TEXT_FIXED;
-    encoding = g_strdup("ASCII");
-    wrap_mode = FALSE;
-    best_fit = TRUE;
-    scale_factor = 1.0;
-    auto_detect_display_mode = TRUE;
-
-    while ((c=getopt(argc,argv,"d:e:f:t:s:w")) != -1) {
-        switch(c)
-        {
-        case 's':
-            best_fit = FALSE;
-            scale_factor = atof(optarg);
-            if (scale_factor<0.1 || scale_factor>3.0) {
-                g_warning("Invalid scale factor \"%f\".\n", scale_factor);
-                usage();
-            }
-            break;
-
-        case 'w':
-            wrap_mode = TRUE;
-            break;
-
-        case 'e':
-            g_free(encoding);
-            encoding = g_strdup(optarg);
-            break;
-
-        case 'd':
-            auto_detect_display_mode = FALSE;
-            if (g_ascii_strcasecmp(optarg,"fixed")==0)
-                dispmode = DISP_MODE_TEXT_FIXED;
-            else if (g_ascii_strcasecmp(optarg,"binary")==0)
-                dispmode = DISP_MODE_BINARY;
-            else if (g_ascii_strcasecmp(optarg,"hex")==0)
-                dispmode = DISP_MODE_HEXDUMP;
-            else if (g_ascii_strcasecmp(optarg,"image")==0)
-                dispmode = DISP_MODE_IMAGE;
-            else if (g_ascii_strcasecmp(optarg,"auto")==0)
-                auto_detect_display_mode = TRUE;
-            else {
-                g_warning("Invalid display mode \"%s\".\n", optarg);
-                usage();
-            }
-            break;
-
-        case 't':
-            tab_size = atoi(optarg);
-            if (tab_size <=0) {
-                g_warning("Invalid tab size \"%s\".\n", optarg);
-                usage();
-            }
-            break;
-
-        case 'f':
-            fixed_limit = atoi(optarg);
-            if (fixed_limit<=0) {
-                g_warning("Invalid fixed limit \"%s\".\n", optarg);
-                usage();
-            }
-            break;
-
-        default:
-            usage();
-            break;
-        }
-    }
-
-    if (optind == argc) {
-        g_warning("Need file name to work with...\n");
-        usage();
-    }
-    filename = g_strdup(argv[optind++]);
+    GtkWidget *viewer;
+    viewer = gviewer_new();
+    gviewer_load_file(GVIEWER(viewer), filename);
+    gviewer_set_fixed_limit(GVIEWER(viewer),GetParam());
+    ASSERT_EQ(GetParam(), gviewer_get_fixed_limit(GVIEWER(viewer)));
 }
 
+//////////////////////////////////////////////////////////////////////////
+
+class ViewerWidgetEncodingTest : public ::testing::TestWithParam<const char *> {};
+
+INSTANTIATE_TEST_CASE_P(InstantiationScaleFactor,
+                        ViewerWidgetEncodingTest,
+                        ::testing::Values("ASCII", "UTF8", "CP437", "CP1251"));
 
-int main(int argc, char *argv[])
+TEST_P(ViewerWidgetEncodingTest, gviewer_set_encoding_test)
 {
-    GtkWidget *window;
     GtkWidget *viewer;
+    viewer = gviewer_new();
+    gviewer_load_file(GVIEWER(viewer), filename);
+    gviewer_set_encoding(GVIEWER(viewer),GetParam());
+    ASSERT_STREQ(GetParam(), gviewer_get_encoding(GVIEWER(viewer)));
+}
 
-    gtk_init(&argc,&argv);
+//////////////////////////////////////////////////////////////////////////
 
-    parse_command_line(argc,argv);
+class ViewerWidgetWrapModeTest : public ::testing::TestWithParam<bool> {};
 
-    window = gtk_window_new(GTK_WINDOW_TOPLEVEL);
-    gtk_container_set_border_width (GTK_CONTAINER (window), 0);
+INSTANTIATE_TEST_CASE_P(InstantiationScaleFactor,
+                        ViewerWidgetWrapModeTest,
+                        ::testing::Bool());
 
+TEST_P(ViewerWidgetWrapModeTest, gviewer_set_wrap_mode_test)
+{
+    GtkWidget *viewer;
     viewer = gviewer_new();
     gviewer_load_file(GVIEWER(viewer), filename);
+    gviewer_set_wrap_mode(GVIEWER(viewer),GetParam());
+    ASSERT_EQ(GetParam(), gviewer_get_wrap_mode(GVIEWER(viewer)));
+}
+
+//////////////////////////////////////////////////////////////////////////
 
-    if (!auto_detect_display_mode)
-        gviewer_set_display_mode(GVIEWER(viewer),dispmode);
+class ViewerWidgetBestFitTest : public ::testing::TestWithParam<bool> {};
 
-    gviewer_set_encoding(GVIEWER(viewer),encoding);
-    gviewer_set_tab_size(GVIEWER(viewer),tab_size);
-    gviewer_set_fixed_limit(GVIEWER(viewer),40);
-    gviewer_set_wrap_mode(GVIEWER(viewer),wrap_mode);
-    gviewer_set_best_fit(GVIEWER(viewer),best_fit);
-    gviewer_set_scale_factor(GVIEWER(viewer),scale_factor);
+INSTANTIATE_TEST_CASE_P(InstantiationScaleFactor,
+                        ViewerWidgetBestFitTest,
+                        ::testing::Bool());
+
+TEST_P(ViewerWidgetBestFitTest, gviewer_set_best_fit_test)
+{
+    GtkWidget *viewer;
+    viewer = gviewer_new();
+    gviewer_load_file(GVIEWER(viewer), filename);
+    gviewer_set_best_fit(GVIEWER(viewer),GetParam());
+    ASSERT_EQ(GetParam(), gviewer_get_best_fit(GVIEWER(viewer)));
+}
 
-    gtk_widget_show(viewer);
+//////////////////////////////////////////////////////////////////////////
 
-    gtk_container_add(GTK_CONTAINER(window), viewer);
-    gtk_widget_show(window);
+class ViewerWidgetScaleFactorTest : public ::testing::TestWithParam<double> {};
 
-    gtk_main();
+INSTANTIATE_TEST_CASE_P(InstantiationScaleFactor,
+                        ViewerWidgetScaleFactorTest,
+                        ::testing::Values(0.1, 0.5, 1, 2, 3));
 
-    return 0;
+TEST_P(ViewerWidgetScaleFactorTest, gviewer_set_scale_factor_test)
+{
+    GtkWidget *viewer;
+    viewer = gviewer_new();
+    gviewer_load_file(GVIEWER(viewer), filename);
+    gviewer_set_scale_factor(GVIEWER(viewer),GetParam());
+    ASSERT_EQ(GetParam(), gviewer_get_scale_factor(GVIEWER(viewer)));
 }
+
+//////////////////////////////////////////////////////////////////////////