[orca] Remove the zombie check from commonAncestor as it causes chattiness
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Remove the zombie check from commonAncestor as it causes chattiness
- Date: Fri, 20 Nov 2015 22:33:05 +0000 (UTC)
commit 81cdcf88eec7c108e6a73221cfea28eb5ff8702b
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Fri Nov 20 17:30:24 2015 -0500
Remove the zombie check from commonAncestor as it causes chattiness
src/orca/script_utilities.py | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
---
diff --git a/src/orca/script_utilities.py b/src/orca/script_utilities.py
index 66f26ba..814c385 100644
--- a/src/orca/script_utilities.py
+++ b/src/orca/script_utilities.py
@@ -260,17 +260,11 @@ class Utilities:
debug.println(debug.LEVEL_FINEST,
"script_utilities.commonAncestor...")
+ # Don't do any Zombie checks here, as tempting and logical as it
+ # may seem as it can lead to chattiness.
if not (a and b):
return None
- if self.isZombie(a) or self.isZombie(b):
- try:
- rolesAreSame = a.getRole() == b.getRole()
- except:
- rolesAreSame = False
- if not rolesAreSame:
- return None
-
if a == b:
return a
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]