[gparted] Make about dialog website link non-clickable (#758131)



commit 5b0465e9a39004f6c7b061a36aaa8df06adbce3b
Author: Curtis Gedak <gedakc gmail com>
Date:   Thu Nov 19 09:42:51 2015 -0700

    Make about dialog website link non-clickable (#758131)
    
    To avoid security implications of invoking a web browser with root
    privileges, make the about dialog website link into a non-clickable
    label.
    
    The set_website_label() method has been available since gtkmm 2.6.
    https://developer.gnome.org/gtkmm/stable/classGtk_1_1AboutDialog.html#aa3d04115d068363be314414899703caa
    
    Bug 758131 - Don't run GUI as root (Was: [wayland] gparted fails to
                 start under wayland)

 src/Win_GParted.cc |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/Win_GParted.cc b/src/Win_GParted.cc
index 63162b3..542b199 100644
--- a/src/Win_GParted.cc
+++ b/src/Win_GParted.cc
@@ -1639,8 +1639,8 @@ void Win_GParted::menu_help_about()
                dialog .set_translator_credits( str_credits ) ;
 
 
-       //the url is not clickable because this would introduce an new dep (gnome-vfsmm) 
-       dialog .set_website( "http://gparted.org"; ) ;
+       //the url is not clickable - should not invoke web browser as root
+       dialog .set_website_label( "http://gparted.org"; ) ;
 
        dialog .run() ;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]