[devhelp/wip/swilmet/misc: 2/3] window: remove redundant code with find_library_equivalent()



commit a97f424c0af1bd41040fb6a887cf7706f96cdb36
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sun Nov 15 16:51:11 2015 +0100

    window: remove redundant code with find_library_equivalent()
    
    find_library_equivalent() returns NULL in case the URI doesn't has one
    of the 4 prefixes.

 src/dh-window.c |   18 +++++++-----------
 1 files changed, 7 insertions(+), 11 deletions(-)
---
diff --git a/src/dh-window.c b/src/dh-window.c
index 097f736..2a6fe42 100644
--- a/src/dh-window.c
+++ b/src/dh-window.c
@@ -908,6 +908,7 @@ window_web_view_decide_policy_cb (WebKitWebView            *web_view,
         const char   *uri;
         WebKitNavigationPolicyDecision *navigation_decision;
         WebKitNavigationAction *navigation_action;
+        gchar *local_uri;
 
         if (type != WEBKIT_POLICY_DECISION_TYPE_NAVIGATION_ACTION)
                 return GDK_EVENT_PROPAGATE;
@@ -930,17 +931,12 @@ window_web_view_decide_policy_cb (WebKitWebView            *web_view,
                 return GDK_EVENT_PROPAGATE;
         }
 
-        if (g_str_has_prefix (uri, "http://library.gnome.org/devel/";) ||
-            g_str_has_prefix (uri, "https://library.gnome.org/devel/";) ||
-            g_str_has_prefix (uri, "http://developer.gnome.org/";) ||
-            g_str_has_prefix (uri, "https://developer.gnome.org/";)) {
-                gchar *local_uri = find_library_equivalent (window, uri);
-                if (local_uri != NULL) {
-                        webkit_policy_decision_ignore (policy_decision);
-                        _dh_window_display_uri (window, local_uri);
-                        g_free (local_uri);
-                        return GDK_EVENT_STOP;
-                }
+        local_uri = find_library_equivalent (window, uri);
+        if (local_uri != NULL) {
+                webkit_policy_decision_ignore (policy_decision);
+                _dh_window_display_uri (window, local_uri);
+                g_free (local_uri);
+                return GDK_EVENT_STOP;
         }
 
         if (!g_str_has_prefix (uri, "file://")) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]