[meld] Fix: bgo #753358 stderr errors when Alt-F4 is used
- From: Kai Willadsen <kaiw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [meld] Fix: bgo #753358 stderr errors when Alt-F4 is used
- Date: Sat, 14 Nov 2015 02:14:27 +0000 (UTC)
commit 7682c9d6980d63551553184bbb07152930d61bc9
Author: Zain <zainengineer gmail com>
Date: Sun Nov 8 12:32:48 2015 +1030
Fix: bgo #753358 stderr errors when Alt-F4 is used
Problem:
When meld is launched from console, usecase is git difftool,
After closing App using Alt+F4 console displays multiple error messages
Error Messages look like
(meld:18521): Gtk-CRITICAL **: gtk_container_foreach: assertion 'GTK_IS_CONTAINER (container)' failed
Cause:
closing window triggers do_window_removed
Unlike when Quit is choosen from Menu, self.quit() is never called
Gtk complains and adds error messages on STDERR
Solution:
When do_window_removed is called check if there are any active windows
If there is no active window, call self.quit()
meld/meldapp.py | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/meld/meldapp.py b/meld/meldapp.py
index 8fd11c9..b0e5308 100644
--- a/meld/meldapp.py
+++ b/meld/meldapp.py
@@ -98,6 +98,8 @@ class MeldApp(Gtk.Application):
def do_window_removed(self, widget):
widget.meldwindow = None
Gtk.Application.do_window_removed(self, widget)
+ if not len(self.get_windows()):
+ self.quit()
# We can't override do_local_command_line because it has no introspection
# annotations: https://bugzilla.gnome.org/show_bug.cgi?id=687912
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]