[vte] widget: Rename some function parameters
- From: Christian Persch <chpe src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [vte] widget: Rename some function parameters
- Date: Fri, 13 Nov 2015 17:27:57 +0000 (UTC)
commit fa3ea1e3a20c2b8d1084b462f74c2dbdcc5afcd8
Author: Christian Persch <chpe gnome org>
Date: Fri Nov 13 18:27:16 2015 +0100
widget: Rename some function parameters
Don't use the same name for function parameters as for
members in VteTerminalPrivate.
src/vte.cc | 20 ++++++++------------
1 files changed, 8 insertions(+), 12 deletions(-)
---
diff --git a/src/vte.cc b/src/vte.cc
index 2c9eb4c..e73fcc7 100644
--- a/src/vte.cc
+++ b/src/vte.cc
@@ -477,8 +477,8 @@ _vte_terminal_mouse_pixels_to_grid (VteTerminal *terminal,
/* Cause certain cells to be repainted. */
void
_vte_invalidate_cells(VteTerminal *terminal,
- glong column_start, gint column_count,
- glong row_start, gint row_count)
+ glong column_start, gint n_columns,
+ glong row_start, gint n_rows)
{
cairo_rectangle_int_t rect;
GtkAllocation allocation;
@@ -486,7 +486,7 @@ _vte_invalidate_cells(VteTerminal *terminal,
if (G_UNLIKELY (!gtk_widget_get_realized(&terminal->widget)))
return;
- if (!column_count || !row_count) {
+ if (!n_columns || !n_rows) {
return;
}
@@ -497,15 +497,11 @@ _vte_invalidate_cells(VteTerminal *terminal,
_vte_debug_print (VTE_DEBUG_UPDATES,
"Invalidating cells at (%ld,%ld)x(%d,%d).\n",
column_start, row_start,
- column_count, row_count);
+ n_columns, n_rows);
_vte_debug_print (VTE_DEBUG_WORK, "?");
- if (!column_count || !row_count) {
- return;
- }
-
- if (column_count == terminal->pvt->column_count &&
- row_count == terminal->pvt->row_count) {
+ if (n_columns == terminal->pvt->column_count &&
+ n_rows == terminal->pvt->row_count) {
_vte_invalidate_all (terminal);
return;
}
@@ -520,7 +516,7 @@ _vte_invalidate_cells(VteTerminal *terminal,
if (rect.x <= 0)
rect.x = 0;
/* Temporarily misuse rect.width for the end x coordinate... */
- rect.width = terminal->pvt->padding.left + (column_start + column_count) * terminal->pvt->char_width
+ 2; /* TODO why 2 and not 1? */
+ rect.width = terminal->pvt->padding.left + (column_start + n_columns) * terminal->pvt->char_width +
2; /* TODO why 2 and not 1? */
if (rect.width >= allocation.width)
rect.width = allocation.width;
/* ... fix that here */
@@ -531,7 +527,7 @@ _vte_invalidate_cells(VteTerminal *terminal,
rect.y = 0;
/* Temporarily misuse rect.height for the end y coordinate... */
- rect.height = terminal->pvt->padding.top + _vte_terminal_row_to_pixel(terminal, row_start +
row_count) + 1;
+ rect.height = terminal->pvt->padding.top + _vte_terminal_row_to_pixel(terminal, row_start + n_rows)
+ 1;
if (rect.height >= allocation.height)
rect.height = allocation.height;
/* ... fix that here */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]