[epiphany] Reenable and placate -Wempty-body



commit 06e5452598ba76b50667e3ef19d94f62808e81eb
Author: Michael Catanzaro <mcatanzaro igalia com>
Date:   Sat Nov 7 16:56:26 2015 -0600

    Reenable and placate -Wempty-body
    
    Looks like some sort of bug in the password migrator, as this
    conditional is probably not intended to do nothing, but whatever.

 configure.ac                |    2 +-
 lib/ephy-profile-migrator.c |    2 --
 2 files changed, 1 insertions(+), 3 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index caf4ea6..abdce32 100644
--- a/configure.ac
+++ b/configure.ac
@@ -38,7 +38,7 @@ AX_COMPILER_FLAGS([WARN_CFLAGS], [WARN_LDFLAGS], [$ax_is_release], [-Wdeclaratio
        dnl TODO: Remove all of these! These warnings should be fixed, not
        dnl silenced. At least, for the most part. -Wswitch-enum really does
        dnl seem pretty dumb.
-       [-Wno-empty-body -Wno-unused-function -Wno-unused-variable -Wno-old-style-definition -Wno-shadow 
-Wno-format-nonliteral -Wno-deprecated-declarations -Wno-switch-enum -Wno-switch-default -Wno-redundant-decls 
-Wno-discarded-qualifiers -Wno-sign-compare])
+       [-Wno-unused-function -Wno-unused-variable -Wno-old-style-definition -Wno-shadow 
-Wno-format-nonliteral -Wno-deprecated-declarations -Wno-switch-enum -Wno-switch-default -Wno-redundant-decls 
-Wno-discarded-qualifiers -Wno-sign-compare])
 
 AC_PROG_CC
 
diff --git a/lib/ephy-profile-migrator.c b/lib/ephy-profile-migrator.c
index 718eb5f..ca46bc4 100644
--- a/lib/ephy-profile-migrator.c
+++ b/lib/ephy-profile-migrator.c
@@ -282,8 +282,6 @@ parse_and_decrypt_signons (const char *signons,
        * exists in version 2 or above
        */
       if (version >= 2) {
-        if (begin < end)
-          /* Skip it */ ;
         begin++;
 
         /* Version 3 has an extra line for further use */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]