[glom] Pass shared_ptr<> by reference, not value.



commit 5fe871d7f003fd30ad336c06edd16723e9b8a924
Author: Murray Cumming <murrayc murrayc com>
Date:   Tue Nov 3 17:29:45 2015 +0100

    Pass shared_ptr<> by reference, not value.

 glom/mode_data/flowtablewithfields.cc |    6 +++---
 glom/mode_data/flowtablewithfields.h  |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/glom/mode_data/flowtablewithfields.cc b/glom/mode_data/flowtablewithfields.cc
index a1cf5bf..2d3085b 100644
--- a/glom/mode_data/flowtablewithfields.cc
+++ b/glom/mode_data/flowtablewithfields.cc
@@ -1010,17 +1010,17 @@ void FlowTableWithFields::on_script_button_clicked(const std::shared_ptr< Layout
   m_signal_script_button_clicked.emit(layout_item);
 }
 
-void FlowTableWithFields::on_entry_edited(const Gnome::Gda::Value& value, const std::shared_ptr<const 
LayoutItem_Field> field)
+void FlowTableWithFields::on_entry_edited(const Gnome::Gda::Value& value, const std::shared_ptr<const 
LayoutItem_Field>& field)
 {
   m_signal_field_edited.emit(field, value);
 }
 
-void FlowTableWithFields::on_entry_choices_changed(const std::shared_ptr<const LayoutItem_Field> field)
+void FlowTableWithFields::on_entry_choices_changed(const std::shared_ptr<const LayoutItem_Field>& field)
 {
   m_signal_field_choices_changed.emit(field);
 }
 
-void FlowTableWithFields::on_entry_open_details_requested(const Gnome::Gda::Value& value, const 
std::shared_ptr<const LayoutItem_Field> field)
+void FlowTableWithFields::on_entry_open_details_requested(const Gnome::Gda::Value& value, const 
std::shared_ptr<const LayoutItem_Field>& field)
 {
   m_signal_field_open_details_requested.emit(field, value);
 }
diff --git a/glom/mode_data/flowtablewithfields.h b/glom/mode_data/flowtablewithfields.h
index 155b27b..bad20f4 100644
--- a/glom/mode_data/flowtablewithfields.h
+++ b/glom/mode_data/flowtablewithfields.h
@@ -203,9 +203,9 @@ private:
 
   //int get_suitable_width(Field::glom_field_type field_type);
 
-  void on_entry_edited(const Gnome::Gda::Value& value, const std::shared_ptr<const LayoutItem_Field> field);
-  void on_entry_choices_changed(const std::shared_ptr<const LayoutItem_Field> field);
-  void on_entry_open_details_requested(const Gnome::Gda::Value& value, const std::shared_ptr<const 
LayoutItem_Field> field);
+  void on_entry_edited(const Gnome::Gda::Value& value, const std::shared_ptr<const LayoutItem_Field>& field);
+  void on_entry_choices_changed(const std::shared_ptr<const LayoutItem_Field>& field);
+  void on_entry_open_details_requested(const Gnome::Gda::Value& value, const std::shared_ptr<const 
LayoutItem_Field>& field);
 
   void on_script_button_clicked(const std::shared_ptr<LayoutItem_Button>& layout_item);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]