[gnome-software] Don't show "Updates" overlay text on feature tiles



commit a10e075de14c5a074134eac41d072a8188bdef93
Author: Kalev Lember <kalevlember gmail com>
Date:   Mon May 25 20:55:57 2015 +0200

    Don't show "Updates" overlay text on feature tiles
    
    The "Updates" text on the feature tiles leads to believe that it's
    possible to update an app by clicking on the tile. This is misleading
    since we don't offer updates on the details page.
    
    Remove the label until we get a way to update individual apps and start
    offering updates on the details page.

 src/gs-app-tile.c     |   11 +----------
 src/gs-feature-tile.c |    6 +-----
 src/gs-popular-tile.c |   11 +----------
 3 files changed, 3 insertions(+), 25 deletions(-)
---
diff --git a/src/gs-app-tile.c b/src/gs-app-tile.c
index d0644df..4898f26 100644
--- a/src/gs-app-tile.c
+++ b/src/gs-app-tile.c
@@ -69,6 +69,7 @@ app_state_changed_idle (gpointer user_data)
        label = gtk_bin_get_child (GTK_BIN (priv->eventbox));
        switch (gs_app_get_state (priv->app)) {
        case AS_APP_STATE_INSTALLED:
+       case AS_APP_STATE_UPDATABLE:
                installed = TRUE;
                name = g_strdup_printf ("%s (%s)",
                                        gs_app_get_name (priv->app),
@@ -95,16 +96,6 @@ app_state_changed_idle (gpointer user_data)
                 * that tells the user the application is being removed */
                gtk_label_set_label (GTK_LABEL (label), _("Removing"));
                break;
-       case AS_APP_STATE_UPDATABLE:
-               installed = TRUE;
-               name = g_strdup_printf ("%s (%s)",
-                                       gs_app_get_name (priv->app),
-                                       _("Updates"));
-               /* TRANSLATORS: this is the small blue label on the tile
-                * that tells the user there is an update for the installed
-                * application available */
-               gtk_label_set_label (GTK_LABEL (label), _("Updates"));
-               break;
        case AS_APP_STATE_QUEUED_FOR_INSTALL:
        case AS_APP_STATE_AVAILABLE:
        default:
diff --git a/src/gs-feature-tile.c b/src/gs-feature-tile.c
index 8c83983..4cddb77 100644
--- a/src/gs-feature-tile.c
+++ b/src/gs-feature-tile.c
@@ -65,14 +65,10 @@ app_state_changed_idle (gpointer user_data)
        case AS_APP_STATE_INSTALLED:
        case AS_APP_STATE_INSTALLING:
        case AS_APP_STATE_REMOVING:
-               name = g_strdup_printf ("%s (%s)",
-                                       gs_app_get_name (priv->app),
-                                       _("Installed"));
-               break;
        case AS_APP_STATE_UPDATABLE:
                name = g_strdup_printf ("%s (%s)",
                                        gs_app_get_name (priv->app),
-                                       _("Updates"));
+                                       _("Installed"));
                break;
        case AS_APP_STATE_AVAILABLE:
        default:
diff --git a/src/gs-popular-tile.c b/src/gs-popular-tile.c
index 8a41b08..0bddf95 100644
--- a/src/gs-popular-tile.c
+++ b/src/gs-popular-tile.c
@@ -70,6 +70,7 @@ app_state_changed_idle (gpointer user_data)
        case AS_APP_STATE_INSTALLED:
        case AS_APP_STATE_INSTALLING:
        case AS_APP_STATE_REMOVING:
+       case AS_APP_STATE_UPDATABLE:
                installed = TRUE;
                name = g_strdup_printf ("%s (%s)",
                                        gs_app_get_name (priv->app),
@@ -78,16 +79,6 @@ app_state_changed_idle (gpointer user_data)
                 * that tells the user the application is installed */
                gtk_label_set_label (GTK_LABEL (label), _("Installed"));
                break;
-       case AS_APP_STATE_UPDATABLE:
-               installed = TRUE;
-               name = g_strdup_printf ("%s (%s)",
-                                       gs_app_get_name (priv->app),
-                                       _("Updates"));
-               /* TRANSLATORS: this is the small blue label on the tile
-                * that tells the user there is an update for the installed
-                * application available */
-               gtk_label_set_label (GTK_LABEL (label), _("Updates"));
-               break;
        case AS_APP_STATE_AVAILABLE:
        default:
                installed = FALSE;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]