[gtksourceview/wip/sortlines] bug fix with last_line, simplify by using g_strcmp0



commit 85f3c687879b81dd7773695fb33c4048b90555b1
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sat May 16 12:24:01 2015 +0200

    bug fix with last_line, simplify by using g_strcmp0

 gtksourceview/gtksourcebuffer.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
---
diff --git a/gtksourceview/gtksourcebuffer.c b/gtksourceview/gtksourcebuffer.c
index 5117959..c0ffa45 100644
--- a/gtksourceview/gtksourcebuffer.c
+++ b/gtksourceview/gtksourcebuffer.c
@@ -2776,7 +2776,7 @@ gtk_source_buffer_sort_lines (GtkSourceBuffer    *buffer,
        gint end_line;
        gint num_lines;
        SortLine *lines;
-       gchar *last_line;
+       gchar *last_line = NULL;
        gint i;
 
        g_return_if_fail (GTK_SOURCE_IS_BUFFER (buffer));
@@ -2864,8 +2864,7 @@ gtk_source_buffer_sort_lines (GtkSourceBuffer    *buffer,
        for (i = 0; i < num_lines; i++)
        {
                if ((flags & GTK_SOURCE_SORT_FLAGS_REMOVE_DUPLICATES) != 0 &&
-                   last_line != NULL &&
-                   (strcmp (last_line, lines[i].line) == 0))
+                   g_strcmp0 (last_line, lines[i].line) == 0)
                {
                        continue;
                }
@@ -2881,8 +2880,8 @@ gtk_source_buffer_sort_lines (GtkSourceBuffer    *buffer,
 
        for (i = 0; i < num_lines; i++)
        {
-               g_free(lines[i].line);
-               g_free(lines[i].key);
+               g_free (lines[i].line);
+               g_free (lines[i].key);
        }
 
        g_free (lines);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]