[libmediaart] extract: Don't print confusing random strerror



commit 1f6a4d9018529bee2a709bebb2ea7c24fa2bb477
Author: Jens Georg <mail jensge org>
Date:   Mon Nov 10 13:27:05 2014 +0100

    extract: Don't print confusing random strerror
    
    debug was printing g_strerror(errno) even in success case, leaving
    weird confusing messages, indicating an error even if symlinking succeeded.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739873

 libmediaart/extract.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/libmediaart/extract.c b/libmediaart/extract.c
index f5abeed..7647957 100644
--- a/libmediaart/extract.c
+++ b/libmediaart/extract.c
@@ -883,7 +883,7 @@ get_heuristic (MediaArtType   type,
                                                g_debug ("symlink('%s' --> '%s'), %s",
                                                         album_art_file_path,
                                                         target,
-                                                        g_strerror (errno));
+                                                        !retval ? g_strerror (errno) : "no error given");
                                        } else {
                                                GFile *art_file;
                                                GFile *target_file;
@@ -944,7 +944,7 @@ get_heuristic (MediaArtType   type,
 
                                                g_debug ("symlink('%s' --> '%s'), %s",
                                                         album_art_file_path, target,
-                                                        g_strerror (errno));
+                                                        !retval ? g_strerror (errno) : "no error given");
                                        }
 
                                        g_object_unref (album_art_file);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]