[gnome-builder] makecache: zero structures when releasing



commit e035bcd13b402a9a060fd9e59792a47d6761b473
Author: Christian Hergert <christian hergert me>
Date:   Wed May 13 17:26:36 2015 -0700

    makecache: zero structures when releasing
    
    This has the added benefit of being resistant to non-standard free paths
    such as short-circuiting during error scenarios.

 libide/autotools/ide-makecache.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/libide/autotools/ide-makecache.c b/libide/autotools/ide-makecache.c
index ced6a01..3ff205e 100644
--- a/libide/autotools/ide-makecache.c
+++ b/libide/autotools/ide-makecache.c
@@ -148,10 +148,10 @@ file_flags_lookup_free (gpointer data)
 {
   FileFlagsLookup *lookup = data;
 
-  g_object_unref (lookup->self);
-  g_object_unref (lookup->file);
-  g_ptr_array_unref (lookup->targets);
-  g_free (lookup->relative_path);
+  g_clear_object (&lookup->self);
+  g_clear_object (&lookup->file);
+  g_clear_pointer (&lookup->targets, g_ptr_array_unref);
+  g_clear_pointer (&lookup->relative_path, g_free);
   g_slice_free (FileFlagsLookup, lookup);
 }
 
@@ -160,8 +160,8 @@ file_targets_lookup_free (gpointer data)
 {
   FileTargetsLookup *lookup = data;
 
-  g_free (lookup->path);
-  g_mapped_file_unref (lookup->mapped);
+  g_clear_pointer (&lookup->path, g_free);
+  g_clear_pointer (&lookup->mapped, g_mapped_file_unref);
   g_slice_free (FileTargetsLookup, lookup);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]