[gnome-builder/wip/greeter] workspace: ensure we save timeout source id



commit 208c924320b18af3f08ac423cc438499ecbe98a7
Author: Christian Hergert <christian hergert me>
Date:   Sun May 10 23:52:31 2015 -0700

    workspace: ensure we save timeout source id
    
    This wasn't getting removed, which causes errors during spurious movement.
    Also, it could cause use after free if closing window during loading.

 src/editor/gb-editor-workspace.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/src/editor/gb-editor-workspace.c b/src/editor/gb-editor-workspace.c
index 75872bc..2662485 100644
--- a/src/editor/gb-editor-workspace.c
+++ b/src/editor/gb-editor-workspace.c
@@ -236,7 +236,9 @@ gb_editor_workspace__project_paned_notify_position (GbEditorWorkspace *self,
 
   if (self->project_tree_position_timeout != 0)
     g_source_remove (self->project_tree_position_timeout);
-  g_timeout_add_seconds (1, save_project_tree_position_timeout, self);
+
+  self->project_tree_position_timeout =
+    g_timeout_add_seconds (1, save_project_tree_position_timeout, self);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]