[gnumeric] xls: plug fuzzed file leaks



commit 0711e8a81a8364291ee1cadddafd66f5e52fcdbe
Author: Morten Welinder <terra gnome org>
Date:   Sun May 10 17:17:39 2015 -0400

    xls: plug fuzzed file leaks

 plugins/excel/ChangeLog       |    2 ++
 plugins/excel/ms-excel-read.c |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)
---
diff --git a/plugins/excel/ChangeLog b/plugins/excel/ChangeLog
index 6fb3c5e..7b80f80 100644
--- a/plugins/excel/ChangeLog
+++ b/plugins/excel/ChangeLog
@@ -1,5 +1,7 @@
 2015-05-10  Morten Welinder  <terra gnome org>
 
+       * ms-excel-read.c (excel_read_CONDFMT): Plug leaks.
+
        * ms-obj.c (ms_read_TXO): Fix maxlen calculation for UTF-16.
 
        * ms-chart.c (chart_write_MARKERFORMAT): Shape map was missing an
diff --git a/plugins/excel/ms-excel-read.c b/plugins/excel/ms-excel-read.c
index a8217fa..79ca607 100644
--- a/plugins/excel/ms-excel-read.c
+++ b/plugins/excel/ms-excel-read.c
@@ -5512,6 +5512,8 @@ excel_read_CONDFMT (BiffQuery *q, ExcelReadSheet *esheet,
        for (i = 0 ; i < num_fmts ; i++) {
                guint16 next;
                if (!ms_biff_query_peek_next (q, &next) || next != BIFF_CF) {
+                       g_object_unref (sc);
+                       g_slist_free_full (regions, g_free);
                        g_warning ("EXCEL: missing CF record");
                        return;
                }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]