[gnumeric] Compilation: please clang.



commit ec9dc59afd7114af7612f1ddee5143ba40d854f3
Author: Morten Welinder <terra gnome org>
Date:   Sat May 9 10:28:01 2015 -0400

    Compilation: please clang.
    
    It evidently wants a literal format string.  "_" hopefully doesn't
    count.

 src/tools/ChangeLog            |    5 +++++
 src/tools/analysis-frequency.c |   11 ++++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)
---
diff --git a/src/tools/ChangeLog b/src/tools/ChangeLog
index 8773b0f..c91d362 100644
--- a/src/tools/ChangeLog
+++ b/src/tools/ChangeLog
@@ -1,3 +1,8 @@
+2015-05-09  Morten Welinder  <terra gnome org>
+
+       * analysis-frequency.c (analysis_tool_frequency_engine_run):
+       Please clang.
+
 2015-05-06  Morten Welinder  <terra gnome org>
 
        * gnm-solver.c (gnm_solver_update_derived): Determine minima,
diff --git a/src/tools/analysis-frequency.c b/src/tools/analysis-frequency.c
index ec175be..7f87a22 100644
--- a/src/tools/analysis-frequency.c
+++ b/src/tools/analysis-frequency.c
@@ -139,20 +139,21 @@ analysis_tool_frequency_engine_run (data_analysis_output_t *dao,
                                           gnm_expr_new_funcall1 (fd_index,
                                                                  gnm_expr_new_constant (val_c)));
                } else {
-                       char const *format;
+                       char *txt;
 
                        switch (info->base.group_by) {
                        case GROUPED_BY_ROW:
-                               format = _("Row %d");
+                               txt = g_strdup_printf (_("Row %d"), col);
                                break;
                        case GROUPED_BY_COL:
-                               format = _("Column %d");
+                               txt = g_strdup_printf (_("Column %d"), col);
                                break;
                        default:
-                               format = _("Area %d");
+                               txt = g_strdup_printf (_("Area %d"), col);
                                break;
                        }
-                       dao_set_cell_printf (dao, col, 1, format, col);
+                       dao_set_cell (dao, col, 1, txt);
+                       g_free (txt);
                }
 
                expr_data = gnm_expr_new_constant (val);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]