[gnumeric] xlsx: plug leaks related to fuzzed files.
- From: Morten Welinder <mortenw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnumeric] xlsx: plug leaks related to fuzzed files.
- Date: Thu, 7 May 2015 02:10:30 +0000 (UTC)
commit db3573f3d007ad621e71ee7f08a0ca812537201d
Author: Morten Welinder <terra gnome org>
Date: Wed May 6 22:10:18 2015 -0400
xlsx: plug leaks related to fuzzed files.
NEWS | 2 +-
plugins/excel/ChangeLog | 5 +++++
plugins/excel/xlsx-read.c | 2 ++
3 files changed, 8 insertions(+), 1 deletions(-)
---
diff --git a/NEWS b/NEWS
index 71dcb1f..f30c52a 100644
--- a/NEWS
+++ b/NEWS
@@ -13,7 +13,7 @@ Morten:
* Fix xlsx save crash related to shared strings. [#748477]
* Solver code refactoring.
* Plug leaks.
- * Fuzzed file fixes. [#748595] [#748597] [#749031]
+ * Fuzzed file fixes. [#748595] [#748597] [#749031] [#749030]
* Make solver check linearity of model.
--------------------------------------------------------------------------
diff --git a/plugins/excel/ChangeLog b/plugins/excel/ChangeLog
index 862efc9..0bb45ff 100644
--- a/plugins/excel/ChangeLog
+++ b/plugins/excel/ChangeLog
@@ -1,3 +1,8 @@
+2015-05-06 Morten Welinder <terra gnome org>
+
+ * xlsx-read.c (xlsx_file_open): Plug leaks related to fuzzed
+ files. Fixes #749030.
+
2015-05-04 Morten Welinder <terra gnome org>
* xlsx-read-drawing.c (xlsx_axis_custom_unit): Allow negative
diff --git a/plugins/excel/xlsx-read.c b/plugins/excel/xlsx-read.c
index 66803d2..2434fbe 100644
--- a/plugins/excel/xlsx-read.c
+++ b/plugins/excel/xlsx-read.c
@@ -5084,6 +5084,8 @@ xlsx_file_open (G_GNUC_UNUSED GOFileOpener const *fo, GOIOContext *context,
if (state.texpr) gnm_expr_top_unref (state.texpr);
if (state.comment) g_object_unref (state.comment);
if (state.cur_style) g_object_unref (state.cur_style);
+ if (state.style_accum) gnm_style_unref (state.style_accum);
+ if (state.border_color) style_color_unref (state.border_color);
workbook_set_saveinfo (state.wb, GO_FILE_FL_AUTO,
go_file_saver_for_id ((state.version == ECMA_376_2006) ?
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]