[gnome-builder] viewstack: fix default viewstack state
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] viewstack: fix default viewstack state
- Date: Mon, 30 Mar 2015 21:23:51 +0000 (UTC)
commit 46fe22f36c40e1d7e6a375873a630da2fdc80822
Author: Christian Hergert <christian hergert me>
Date: Mon Mar 30 14:23:10 2015 -0700
viewstack: fix default viewstack state
document selector should be insensitive, and doc list should be hidden.
data/ui/gb-view-stack.ui | 5 ++++-
src/views/gb-view-stack.c | 15 +++++++++++++++
2 files changed, 19 insertions(+), 1 deletions(-)
---
diff --git a/data/ui/gb-view-stack.ui b/data/ui/gb-view-stack.ui
index a29aa18..dafd191 100644
--- a/data/ui/gb-view-stack.ui
+++ b/data/ui/gb-view-stack.ui
@@ -64,7 +64,7 @@
</child>
<child>
<object class="GtkMenuButton" id="views_button">
- <property name="visible">true</property>
+ <property name="visible">false</property>
<property name="popover">views_popover</property>
<style>
<class name="dim-label"/>
@@ -86,6 +86,9 @@
<object class="GtkMenuButton" id="document_button">
<property name="hexpand">true</property>
<property name="popover">popover</property>
+ <!-- Sensitive is not being respected,
+ likely due to popover being set. -->
+ <property name="sensitive">false</property>
<property name="visible">true</property>
<style>
<class name="dim-label"/>
diff --git a/src/views/gb-view-stack.c b/src/views/gb-view-stack.c
index c91571c..60dd602 100644
--- a/src/views/gb-view-stack.c
+++ b/src/views/gb-view-stack.c
@@ -545,6 +545,21 @@ gb_view_stack_init (GbViewStack *self)
self,
G_CONNECT_SWAPPED);
+ /*
+ * FIXME:
+ *
+ * https://bugzilla.gnome.org/show_bug.cgi?id=747060
+ *
+ * Setting sensitive in the template is getting changed out from under us.
+ * Likely due to the popover item being set (conflation of having a popover
+ * vs wanting sensitivity). So we will just override it here.
+ *
+ * Last tested Gtk+ was 3.16.0.
+ */
+ g_object_set (self->document_button,
+ "sensitive", FALSE,
+ NULL);
+
gb_widget_set_context_handler (self, gb_view_stack_context_handler);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]