[gedit/wip/merge-encoding-settings] EncodingsComboBox: update menu even if dialog was cancelled



commit 7c401b556ee4a7b80c97532119e9ba5f0abfc9dc
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sat Mar 28 16:42:47 2015 +0100

    EncodingsComboBox: update menu even if dialog was cancelled
    
    Because we can now click on Reset and then Cancel.
    Maybe a better solution is to move the Reset button to a dialog
    response.

 gedit/gedit-encodings-combo-box.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)
---
diff --git a/gedit/gedit-encodings-combo-box.c b/gedit/gedit-encodings-combo-box.c
index 88f19da..2d7f180 100644
--- a/gedit/gedit-encodings-combo-box.c
+++ b/gedit/gedit-encodings-combo-box.c
@@ -169,13 +169,9 @@ dialog_response_cb (GtkDialog              *dialog,
                     gint                    response_id,
                     GeditEncodingsComboBox *menu)
 {
-       if (response_id == GTK_RESPONSE_OK)
-       {
-               update_menu (menu);
-       }
-
        if (response_id != GTK_RESPONSE_HELP)
        {
+               update_menu (menu);
                gtk_widget_destroy (GTK_WIDGET (dialog));
        }
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]