[easytag] Remove maximum log lines setting
- From: David King <davidk src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [easytag] Remove maximum log lines setting
- Date: Thu, 26 Mar 2015 08:17:09 +0000 (UTC)
commit ecef6029d0a150d421984a4155a9341ece97a8af
Author: David King <amigadave amigadave com>
Date: Thu Mar 26 09:14:40 2015 +0100
Remove maximum log lines setting
Do not restrict the maximum number of lines in the log.
data/org.gnome.EasyTAG.gschema.xml | 7 -------
data/preferences_dialog.ui | 25 -------------------------
src/log.c | 12 ------------
src/preferences_dialog.c | 9 +--------
4 files changed, 1 insertions(+), 52 deletions(-)
---
diff --git a/data/org.gnome.EasyTAG.gschema.xml b/data/org.gnome.EasyTAG.gschema.xml
index cf04333..ea44451 100644
--- a/data/org.gnome.EasyTAG.gschema.xml
+++ b/data/org.gnome.EasyTAG.gschema.xml
@@ -193,13 +193,6 @@
<default>'ascending-track-number'</default>
</key>
- <key name="log-lines" type="u">
- <summary>Number of log lines</summary>
- <description>The maximum number of lines to keep in the log</description>
- <default>50</default>
- <range min="10" max="1500" />
- </key>
-
<key name="log-show" type="b">
<summary>Show the log</summary>
<description>Whether to show the log in the main window</description>
diff --git a/data/preferences_dialog.ui b/data/preferences_dialog.ui
index 0711109..c700c4e 100644
--- a/data/preferences_dialog.ui
+++ b/data/preferences_dialog.ui
@@ -20,11 +20,6 @@
<property name="step-increment">1.0</property>
<property name="upper">65535.0</property>
</object>
- <object class="GtkAdjustment" id="log_lines_adjustment">
- <property name="lower">10.0</property>
- <property name="step-increment">10.0</property>
- <property name="upper">1500.0</property>
- </object>
<object class="GtkAdjustment" id="tags_disc_adjustment">
<property name="lower">1.0</property>
<property name="step-increment">1.0</property>
@@ -135,26 +130,6 @@
</object>
</child>
<child>
- <object class="GtkBox" id="log_lines_box">
- <property name="margin-left">12</property>
- <property name="spacing">12</property>
- <property name="visible">True</property>
- <child>
- <object class="GtkLabel" id="log_lines_label">
- <property name="label" translatable="yes">Maximum number of lines:</property>
- <property name="visible">True</property>
- </object>
- </child>
- <child>
- <object class="GtkSpinButton" id="log_lines_button">
- <property name="adjustment">log_lines_adjustment</property>
- <property name="tooltip-text" translatable="yes">The maximum number of lines
to keep in the log</property>
- <property name="visible">True</property>
- </object>
- </child>
- </object>
- </child>
- <child>
<object class="GtkLabel" id="general_label">
<property name="halign">start</property>
<property name="label" translatable="yes">General</property>
diff --git a/src/log.c b/src/log.c
index c347120..ad3eaa7 100644
--- a/src/log.c
+++ b/src/log.c
@@ -287,7 +287,6 @@ Log_Print (EtLogAreaKind error_type, const gchar * const format, ...)
va_list args;
gchar *string;
gchar *time;
- guint n_items;
GtkTreeIter iter;
static gboolean first_time = TRUE;
static gchar *file_path = NULL;
@@ -307,17 +306,6 @@ Log_Print (EtLogAreaKind error_type, const gchar * const format, ...)
time = Log_Format_Date ();
- /* Remove lines that exceed the limit. */
- n_items = (guint)gtk_tree_model_iter_n_children (GTK_TREE_MODEL (priv->log_model),
- NULL);
-
- if (n_items > g_settings_get_uint (MainSettings, "log-lines") - 1
- && gtk_tree_model_get_iter_first (GTK_TREE_MODEL (priv->log_model),
- &iter))
- {
- gtk_list_store_remove (GTK_LIST_STORE (priv->log_model), &iter);
- }
-
gtk_list_store_insert_with_values (priv->log_model, &iter, G_MAXINT,
LOG_ICON_NAME,
get_icon_name_from_error_kind (error_type),
diff --git a/src/preferences_dialog.c b/src/preferences_dialog.c
index 32138fb..b329bff 100644
--- a/src/preferences_dialog.c
+++ b/src/preferences_dialog.c
@@ -217,7 +217,6 @@ create_preferences_dialog (EtPreferencesDialog *self)
GtkWidget *ChangedFilesDisplayedToBold;
GtkWidget *SortingFileCaseSensitive;
GtkWidget *ShowLogView;
- GtkWidget *LogMaxLinesSpinButton;
GtkWidget *ReplaceIllegalCharactersInFilename;
GtkWidget *PreserveModificationTime;
GtkWidget *UpdateParentDirectoryModificationTime;
@@ -373,13 +372,7 @@ create_preferences_dialog (EtPreferencesDialog *self)
g_settings_bind (MainSettings, "log-show", ShowLogView, "active",
G_SETTINGS_BIND_DEFAULT);
- /* Max number of lines. */
- LogMaxLinesSpinButton = GTK_WIDGET (gtk_builder_get_object (builder,
- "log_lines_button"));
- g_settings_bind (MainSettings, "log-lines", LogMaxLinesSpinButton,
- "value", G_SETTINGS_BIND_DEFAULT);
-
- /* Show header informantion. */
+ /* Show header information. */
ShowHeaderInfos = GTK_WIDGET (gtk_builder_get_object (builder,
"header_show_check"));
g_settings_bind (MainSettings, "file-show-header", ShowHeaderInfos,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]