[gnome-builder] libide: add IdeSourceView::cycle-completion to move through results

[Christian Hergert <chergert src gnome org>]

commit 026ad1630d1d96919b7c8557d595d70323da2e33
Author: Christian Hergert <christian hergert me>
Date:   Wed Mar 4 16:57:47 2015 -0800

    libide: add IdeSourceView::cycle-completion to move through results
    
    It is handy to be able to propagate an event from the source view to
    cycle through events in the completion window. This let's us do so
    from a keybinding.

 libide/ide-source-view.c |   85 ++++++++++++++++++++++++++++++++++++++++++++++
 libide/ide-source-view.h |    2 +
 2 files changed, 87 insertions(+), 0 deletions(-)
---
diff --git a/libide/ide-source-view.c b/libide/ide-source-view.c
index b05814e..2109d65 100644
--- a/libide/ide-source-view.c
+++ b/libide/ide-source-view.c
@@ -78,6 +78,7 @@ typedef struct
   gulong                       buffer_notify_language_handler;
 
   guint                        auto_indent : 1;
+  guint                        completion_visible : 1;
   guint                        insert_matching_brace : 1;
   guint                        overwrite_braces : 1;
   guint                        show_grid_lines : 1;
@@ -104,6 +105,7 @@ enum {
 enum {
   ACTION,
   CLEAR_SELECTION,
+  CYCLE_COMPLETION,
   INSERT_AT_CURSOR_AND_INDENT,
   JUMP,
   MOVEMENT,
@@ -1470,6 +1472,43 @@ ide_source_view_real_clear_selection (IdeSourceView *self)
 }
 
 static void
+ide_source_view_real_cycle_completion (IdeSourceView    *self,
+                                       GtkDirectionType  direction)
+{
+  IdeSourceViewPrivate *priv = ide_source_view_get_instance_private (self);
+  GtkSourceView *source_view = (GtkSourceView *)self;
+  GtkSourceCompletion *completion;
+
+  g_assert (IDE_IS_SOURCE_VIEW (self));
+
+  completion = gtk_source_view_get_completion (source_view);
+
+  if (!priv->completion_visible)
+    {
+      g_signal_emit_by_name (self, "show-completion");
+      return;
+    }
+
+  switch (direction)
+    {
+    case GTK_DIR_TAB_FORWARD:
+    case GTK_DIR_DOWN:
+      g_signal_emit_by_name (completion, "move-cursor", GTK_SCROLL_STEPS, 1);
+      break;
+
+    case GTK_DIR_TAB_BACKWARD:
+    case GTK_DIR_UP:
+      g_signal_emit_by_name (completion, "move-cursor", GTK_SCROLL_STEPS, -1);
+      break;
+
+    case GTK_DIR_LEFT:
+    case GTK_DIR_RIGHT:
+    default:
+      break;
+    }
+}
+
+static void
 ide_source_view_real_insert_at_cursor_and_indent (IdeSourceView *self,
                                                   const gchar   *str)
 {
@@ -1634,11 +1673,28 @@ ide_source_view_real_movement (IdeSourceView         *self,
 }
 
 static void
+ide_source_view__completion_hide_cb (IdeSourceView       *self,
+                                     GtkSourceCompletion *completion)
+{
+  IdeSourceViewPrivate *priv = ide_source_view_get_instance_private (self);
+  priv->completion_visible = FALSE;
+}
+
+static void
+ide_source_view__completion_show_cb (IdeSourceView       *self,
+                                     GtkSourceCompletion *completion)
+{
+  IdeSourceViewPrivate *priv = ide_source_view_get_instance_private (self);
+  priv->completion_visible = TRUE;
+}
+
+static void
 ide_source_view_constructed (GObject *object)
 {
   IdeSourceView *self = (IdeSourceView *)object;
   IdeSourceViewPrivate *priv = ide_source_view_get_instance_private (self);
   GtkSourceGutter *gutter;
+  GtkSourceCompletion *completion;
   gboolean visible;
 
   G_OBJECT_CLASS (ide_source_view_parent_class)->constructed (object);
@@ -1646,6 +1702,23 @@ ide_source_view_constructed (GObject *object)
   if (!priv->mode)
     ide_source_view_real_set_mode (self, "default", IDE_SOURCE_VIEW_MODE_TYPE_PERMANENT);
 
+  /*
+   * Completion does not have a way to retrieve visibility, so we need to track that ourselves
+   * by connecting to hide/show. We use this to know if we need to move to the next item in the
+   * result set during IdeSourceView:cycle-completion.
+   */
+  completion = gtk_source_view_get_completion (GTK_SOURCE_VIEW (self));
+  g_signal_connect_object (completion,
+                           "show",
+                           G_CALLBACK (ide_source_view__completion_show_cb),
+                           self,
+                           G_CONNECT_SWAPPED | G_CONNECT_AFTER);
+  g_signal_connect_object (completion,
+                           "hide",
+                           G_CALLBACK (ide_source_view__completion_hide_cb),
+                           self,
+                           G_CONNECT_SWAPPED | G_CONNECT_AFTER);
+
   gutter = gtk_source_view_get_gutter (GTK_SOURCE_VIEW (self), GTK_TEXT_WINDOW_LEFT);
 
   priv->line_change_renderer = g_object_new (IDE_TYPE_LINE_CHANGE_GUTTER_RENDERER,
@@ -1811,6 +1884,7 @@ ide_source_view_class_init (IdeSourceViewClass *klass)
 
   klass->action = ide_source_view_real_action;
   klass->clear_selection = ide_source_view_real_clear_selection;
+  klass->cycle_completion = ide_source_view_real_cycle_completion;
   klass->insert_at_cursor_and_indent = ide_source_view_real_insert_at_cursor_and_indent;
   klass->jump = ide_source_view_real_jump;
   klass->movement = ide_source_view_real_movement;
@@ -1904,6 +1978,17 @@ ide_source_view_class_init (IdeSourceViewClass *klass)
                   G_TYPE_NONE,
                   0);
 
+  gSignals [CYCLE_COMPLETION] =
+    g_signal_new ("cycle-completion",
+                  G_TYPE_FROM_CLASS (klass),
+                  G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                  G_STRUCT_OFFSET (IdeSourceViewClass, cycle_completion),
+                  NULL, NULL,
+                  g_cclosure_marshal_VOID__ENUM,
+                  G_TYPE_NONE,
+                  1,
+                  GTK_TYPE_DIRECTION_TYPE);
+
   gSignals [INSERT_AT_CURSOR_AND_INDENT] =
     g_signal_new ("insert-at-cursor-and-indent",
                   G_TYPE_FROM_CLASS (klass),
diff --git a/libide/ide-source-view.h b/libide/ide-source-view.h
index 9637bc7..6ce3045 100644
--- a/libide/ide-source-view.h
+++ b/libide/ide-source-view.h
@@ -163,6 +163,8 @@ struct _IdeSourceViewClass
                                        const gchar             *action_name,
                                        const gchar             *param);
   void (*clear_selection)             (IdeSourceView           *self);
+  void (*cycle_completion)            (IdeSourceView           *self,
+                                       GtkDirectionType         direction);
   void (*insert_at_cursor_and_indent) (IdeSourceView           *self,
                                        const gchar             *str);
   void (*movement)                    (IdeSourceView           *self,