[gnome-initial-setup/shell/4765: 195/362] network: Always enable the 'skip' button by default when refreshing the list



commit 38af34bd3e13a05ae0a0c29abf3c37557f22b2af
Author: Mario Sanchez Prada <mario endlessm com>
Date:   Thu Sep 4 17:51:26 2014 +0100

    network: Always enable the 'skip' button by default when refreshing the list
    
    This way we avoid potential problems (and [endlessm/eos-shell#3563],
    hopefully), by making sure we only disable that button later on once
    it's confirmed that a network connection has already been established.
    
    [endlessm/eos-shell#3563]

 .../pages/network/gis-network-page.c               |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/gnome-initial-setup/pages/network/gis-network-page.c 
b/gnome-initial-setup/pages/network/gis-network-page.c
index ccc9bad..68c04de 100644
--- a/gnome-initial-setup/pages/network/gis-network-page.c
+++ b/gnome-initial-setup/pages/network/gis-network-page.c
@@ -392,6 +392,10 @@ refresh_wireless_list (GisNetworkPage *page)
 
   priv->refreshing = TRUE;
 
+  /* Ensure that the 'skip' button is never disabled by default, to avoid
+     potential issues like the one described in issue eos-shell/3563. */
+  gtk_widget_set_sensitive (priv->skip_button, TRUE);
+
   if (NM_IS_DEVICE_WIFI (priv->nm_device)) {
     state = nm_device_get_state (priv->nm_device);
 
@@ -402,8 +406,6 @@ refresh_wireless_list (GisNetworkPage *page)
          list widget is enabled, due to the property binding the button and the list. */
       gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (priv->skip_button), FALSE);
       gtk_widget_set_sensitive (priv->skip_button, FALSE);
-    } else {
-      gtk_widget_set_sensitive (priv->skip_button, TRUE);
     }
 
     list = WID ("network-list");


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]