[orca] Fix for bug 746400 - Speak child position breaks Qt menu item presentation



commit 20528c31bdb97d2ac87df157e5314e80fec3dd66
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Wed Mar 18 10:50:15 2015 -0400

    Fix for bug 746400 - Speak child position breaks Qt menu item presentation
    
    This regression was introduced by the fix for bug 746086. isLayoutOnly()
    was checking for dead accessibles. When we stopped calling it, we stopped
    doing this sanity check. And there are dead accessibles in certain Qt menus.

 src/orca/script_utilities.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/orca/script_utilities.py b/src/orca/script_utilities.py
index 473631f..5b53446 100644
--- a/src/orca/script_utilities.py
+++ b/src/orca/script_utilities.py
@@ -2592,7 +2592,7 @@ class Utilities:
         parent = self.getFunctionalParent(obj)
         siblings = self.getFunctionalChildren(parent)
         layoutRoles = [pyatspi.ROLE_SEPARATOR, pyatspi.ROLE_TEAROFF_MENU_ITEM]
-        isNotLayoutOnly = lambda x: x and not x.getRole() in layoutRoles
+        isNotLayoutOnly = lambda x: not (self.isZombie(x) or x.getRole() in layoutRoles)
         siblings = list(filter(isNotLayoutOnly, siblings))
         if not (siblings and obj in siblings):
             return -1, -1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]