[gnome-sudoku] Remove unnecessary 'finished' signal
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-sudoku] Remove unnecessary 'finished' signal
- Date: Tue, 17 Mar 2015 13:32:29 +0000 (UTC)
commit a1cbdbf04a75f04ab0ade549535696c8492a0742
Author: Iulian Radu <iulian radu67 gmail com>
Date: Tue Mar 17 11:19:32 2015 +0200
Remove unnecessary 'finished' signal
https://bugzilla.gnome.org/show_bug.cgi?id=736773
src/gnome-sudoku.vala | 3 +--
src/print-dialog.vala | 8 ++------
2 files changed, 3 insertions(+), 8 deletions(-)
---
diff --git a/src/gnome-sudoku.vala b/src/gnome-sudoku.vala
index 789aed8..48c6bcb 100644
--- a/src/gnome-sudoku.vala
+++ b/src/gnome-sudoku.vala
@@ -495,8 +495,7 @@ public class Sudoku : Gtk.Application
print_action.set_enabled (false);
print_multiple_action.set_enabled (false);
var print_dialog = new PrintDialog (saver, window);
- print_dialog.finished.connect (() => {
- print_dialog.destroy ();
+ print_dialog.destroy.connect (() => {
this.print_action.set_enabled (main_stack.get_visible_child_name () == "frame");
this.print_multiple_action.set_enabled (true);
});
diff --git a/src/print-dialog.vala b/src/print-dialog.vala
index 1be7ef5..b1166cd 100644
--- a/src/print-dialog.vala
+++ b/src/print-dialog.vala
@@ -45,10 +45,6 @@ public class PrintDialog : Gtk.Dialog
private Cancellable cancellable;
- /* After emitting our response, we continue to asynchronously generate puzzles
- in the background. This signal indicates when we are really finished. */
- public signal void finished ();
-
private const string DIFFICULTY_KEY_NAME = "print-multiple-sudoku-difficulty";
public PrintDialog (SudokuSaver saver, Gtk.Window window)
@@ -118,7 +114,7 @@ public class PrintDialog : Gtk.Dialog
{
if (response != Gtk.ResponseType.OK)
{
- finished ();
+ destroy ();
return;
}
@@ -171,7 +167,7 @@ public class PrintDialog : Gtk.Dialog
}
}
- finished ();
+ destroy ();
});
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]