[grilo] core: Fix warning when unloading a plugin that failed to load



commit ee8d5558bf5d5a2b07e88afe7928df79b36f45da
Author: Bastien Nocera <hadess hadess net>
Date:   Thu Mar 5 14:15:08 2015 +0100

    core: Fix warning when unloading a plugin that failed to load
    
    This warning is normal:
    (totem:17205): Grilo-WARNING **: [registry] grl-registry.c:1130: Failed to open module: libicui18n.so.52: 
cannot open shared object file: No such file or directory
    
    This one isn't:
    (totem:8432): GModule-CRITICAL **: g_module_close: assertion 'module != NULL' failed
    
    This patch fixes the latter.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745676

 src/grl-registry.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/src/grl-registry.c b/src/grl-registry.c
index fb41f78..8421ac4 100644
--- a/src/grl-registry.c
+++ b/src/grl-registry.c
@@ -558,8 +558,7 @@ activate_plugin (GrlRegistry *registry,
                  GRL_CORE_ERROR,
                  GRL_CORE_ERROR_LOAD_PLUGIN_FAILED,
                  _("Failed to initialize plugin from %s"), grl_plugin_get_filename (plugin));
-    g_module_close (grl_plugin_get_module (plugin));
-    grl_plugin_set_module (plugin, NULL);
+    shutdown_plugin (plugin);
     return FALSE;
   }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]