[gnome-continuous/gnome-3-14: 5/19] testbase: Always clean up overlay disk image



commit 52cad741fc7c06f015a808b94bb74e46e0bff794
Author: Colin Walters <walters verbum org>
Date:   Sat Dec 20 18:56:03 2014 -0500

    testbase: Always clean up overlay disk image
    
    We were leaking them on integrationtest failure, which accumulated
    quickly.

 src/js/tasks/testbase.js |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/src/js/tasks/testbase.js b/src/js/tasks/testbase.js
index 4d3a4a7..4013735 100644
--- a/src/js/tasks/testbase.js
+++ b/src/js/tasks/testbase.js
@@ -520,10 +520,9 @@ const TestOneDisk = new Lang.Class({
             this._parentTask._postQemu(mntdir, cancellable);
         } finally {
             gfmnt.umount(cancellable);
+            GSystem.shutil_rm_rf(diskClone, cancellable);
         }
 
-        GSystem.shutil_rm_rf(diskClone, cancellable);
-
         if (this._failed) {
             throw new Error(this._failedMessage);
         }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]