[gvfs] metadata: return if meta_tree_refresh failed
- From: Ondrej Holy <oholy src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gvfs] metadata: return if meta_tree_refresh failed
- Date: Wed, 4 Mar 2015 13:22:59 +0000 (UTC)
commit 56326e463a56afa0e632baad4c94faa7aa154486
Author: Ondrej Holy <oholy redhat com>
Date: Fri Feb 20 17:33:56 2015 +0100
metadata: return if meta_tree_refresh failed
G_UNLOCK is called twice if meta_tree_refresh fails and also concurrent
access is possible on cached_trees. However this isn't problem currently,
because meta_tree_lookup_by_name is always called with for_write=FALSE
(except for meta-set testing utility), so this if statement is never issued.
https://bugzilla.gnome.org/show_bug.cgi?id=598561
metadata/metatree.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/metadata/metatree.c b/metadata/metatree.c
index 2983e5d..0fe29a1 100644
--- a/metadata/metatree.c
+++ b/metadata/metatree.c
@@ -547,7 +547,7 @@ meta_tree_lookup_by_name (const char *name,
return tree;
meta_tree_unref (tree);
- tree = NULL;
+ return NULL;
}
filename = g_build_filename (g_get_user_data_dir (), "gvfs-metadata", name, NULL);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]