[epiphany/wip/autocrap: 17/37] Reenable -Wmissing-prototype
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/wip/autocrap: 17/37] Reenable -Wmissing-prototype
- Date: Tue, 30 Jun 2015 15:39:52 +0000 (UTC)
commit 7573f26fb584acf179ddcbc084b2b8aebfed53df
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Mon Jun 29 17:15:27 2015 -0500
Reenable -Wmissing-prototype
-Wmissing-prototype is good. Suppressing it for the entire project was a
bad idea.
We'll need to keep -Wno-deprecated-declarations until we can manage to
move away from GtkUIManager, GtkAction, and friends.
I kind of want to remove -Wdeclaration-after-statement as well, because
it is 2015 and it's good to minimize the scope of your variable
declarations by declaring them at point of first use, but this one is
worth discussing before changing.
configure.ac | 2 +-
embed/web-extension/ephy-web-extension-main.c | 5 +++++
2 files changed, 6 insertions(+), 1 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index 8d8c99c..88ff37a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -55,7 +55,7 @@ AX_CHECK_ENABLE_DEBUG([yes])
AX_COMPILER_FLAGS([WARN_CFLAGS], [WARN_LDFLAGS])
AX_CODE_COVERAGE
-WARN_CFLAGS="$WARN_CFLAGS -Wdeclaration-after-statement -Wno-deprecated-declarations -Wno-missing-prototypes"
+WARN_CFLAGS="$WARN_CFLAGS -Wdeclaration-after-statement -Wno-deprecated-declarations"
GLIB_REQUIRED=2.38.0
GTK_REQUIRED=3.13.0
diff --git a/embed/web-extension/ephy-web-extension-main.c b/embed/web-extension/ephy-web-extension-main.c
index 13076bc..f3891ca 100644
--- a/embed/web-extension/ephy-web-extension-main.c
+++ b/embed/web-extension/ephy-web-extension-main.c
@@ -33,6 +33,11 @@ name_acquired_cb (GDBusConnection *connection,
ephy_web_extension_dbus_register (extension, connection);
}
+/* Placate -Wmissing-prototype */
+void
+webkit_web_extension_initialize_with_user_data (WebKitWebExtension *extension,
+ GVariant *user_data);
+
G_MODULE_EXPORT void
webkit_web_extension_initialize_with_user_data (WebKitWebExtension *extension,
GVariant *user_data)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]