[gimp] Bug 750874 - Displayed colors look clipped after profile conversion...



commit e669c6dd050ceb4285a5fb3aaa111d844d40c2ca
Author: Michael Natterer <mitch gimp org>
Date:   Mon Jun 29 10:22:22 2015 +0200

    Bug 750874 - Displayed colors look clipped after profile conversion...
    
    ...but they aren't clipped
    
    gimp_display_shell_profile_can_convert_to_u8(): allow the shortcut of
    converting directly to 8-bit for display only for GIMP_COMPONENT_TYPE_U8.
    
    This might be an lcms bug, the code can be enabled again for U16 and
    U32 if it's indeed an lcms bug and it gets fixed.

 app/display/gimpdisplayshell-profile.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
---
diff --git a/app/display/gimpdisplayshell-profile.c b/app/display/gimpdisplayshell-profile.c
index 38cc9e2..8157639 100644
--- a/app/display/gimpdisplayshell-profile.c
+++ b/app/display/gimpdisplayshell-profile.c
@@ -148,8 +148,13 @@ gimp_display_shell_profile_can_convert_to_u8 (GimpDisplayShell *shell)
       switch (gimp_image_get_component_type (image))
         {
         case GIMP_COMPONENT_TYPE_U8:
+#if 0
+          /* would like to convert directly for these too, but it
+           * produces inferior results, see bug 750874
+           */
         case GIMP_COMPONENT_TYPE_U16:
         case GIMP_COMPONENT_TYPE_U32:
+#endif
           return TRUE;
 
         default:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]