[gnome-software/wip/mak/limba] limba: remove the dummy icon and some cruft

[Matthias Klumpp <mak src gnome org>]

commit ddf7bcf38140ae8f9ed9eef03167cf9f9c696f88
Author: Matthias Klumpp <matthias tenstral net>
Date:   Fri Jun 26 15:19:58 2015 +0200

    limba: remove the dummy icon and some cruft
    
    The code is ready now, except for the updater part. There are also
    several bugs in appstream-glib which needs to be fixed before this patch
    can be merged.

 src/plugins/gs-plugin-limba.c |   31 +++++++------------------------
 1 files changed, 7 insertions(+), 24 deletions(-)
---
diff --git a/src/plugins/gs-plugin-limba.c b/src/plugins/gs-plugin-limba.c
index baf9a54..d1e9fe6 100644
--- a/src/plugins/gs-plugin-limba.c
+++ b/src/plugins/gs-plugin-limba.c
@@ -61,19 +61,6 @@ gs_plugin_destroy (GsPlugin *plugin)
 }
 
 /**
- * gs_plugin_add_search:
- */
-gboolean
-gs_plugin_add_search (GsPlugin *plugin,
-                     gchar **values,
-                     GList **list,
-                     GCancellable *cancellable,
-                     GError **error)
-{
-       return TRUE;
-}
-
-/**
  * gs_plugin_refine_app:
  */
 static gboolean
@@ -112,9 +99,6 @@ gs_plugin_refine_app (GsPlugin *plugin, GsApp *app, GError **error)
 
        gs_app_set_version (app, li_pkg_info_get_version (pki));
 
-       /* FIXME: Simply have it use the Limba-provided icons */
-       gs_app_set_pixbuf (app, gdk_pixbuf_new_from_file ("/usr/share/icons/hicolor/48x48/apps/meld.png", 
NULL));
-
        return TRUE;
 }
 
@@ -251,7 +235,7 @@ gs_plugin_add_sources (GsPlugin *plugin,
                       GCancellable *cancellable,
                       GError **error)
 {
-       /* TODO: Limba does not expose "simple" API for this - add this feature later. */
+       /* TODO: Limba does not expose "simple" API for this yet - add this feature later. */
 
        return TRUE;
 }
@@ -265,15 +249,11 @@ gs_plugin_add_updates (GsPlugin *plugin,
                       GCancellable *cancellable,
                       GError **error)
 {
-
-       _cleanup_object_unref_ LiManager *mgr = NULL;
        _cleanup_list_free_ GList *updates = NULL;
        GList *l;
        GError *local_error = NULL;
 
-       mgr = li_manager_new ();
-
-       updates = li_manager_get_update_list (mgr, &local_error);
+       updates = li_manager_get_update_list (plugin->priv->mgr, &local_error);
        if (local_error != NULL) {
                g_propagate_error (error, local_error);
                return FALSE;
@@ -285,11 +265,14 @@ gs_plugin_add_updates (GsPlugin *plugin,
                LiUpdateItem *uitem = LI_UPDATE_ITEM (l->data);
 
                old_p = li_update_item_get_installed_pkg (uitem);
-               //new_p = li_update_item_get_available_pkg (uitem);
 
                /* FIXME: We actually want the AppStream ID of the Limba bundle here.
-                * We can fetch that from the AS data (get_cpt_data()) */
+                * We can fetch that from the AS data (get_cpt_data())
+                * GS currently does not allow updates from packages with empty package-ids,
+                * this needs to be fixed in GS before the Limba code can work.
+                */
                app = gs_app_new (li_pkg_info_get_name (old_p));
+
                gs_app_set_management_plugin (app, "Limba");
                gs_app_set_state (app, AS_APP_STATE_UPDATABLE);
                gs_app_set_kind (app, GS_APP_KIND_PACKAGE);