[gnome-todo] manager: fix use-after-free errors
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-todo] manager: fix use-after-free errors
- Date: Thu, 25 Jun 2015 04:42:17 +0000 (UTC)
commit afa2b0f8bf7be20125038598fb69f1bc0070f5a1
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Thu Jun 25 01:41:11 2015 -0300
manager: fix use-after-free errors
src/gtd-manager.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/gtd-manager.c b/src/gtd-manager.c
index 08b6867..4b1da69 100644
--- a/src/gtd-manager.c
+++ b/src/gtd-manager.c
@@ -460,8 +460,6 @@ gtd_manager__create_task_finished (GObject *client,
gtd_object_set_ready (GTD_OBJECT (data->data), TRUE);
- g_free (data);
-
if (error)
{
g_warning ("%s: %s: %s",
@@ -470,6 +468,7 @@ gtd_manager__create_task_finished (GObject *client,
error->message);
g_error_free (error);
+ g_free (data);
return;
}
else
@@ -501,6 +500,7 @@ gtd_manager__create_task_finished (GObject *client,
}
g_clear_pointer (&dt, g_date_time_unref);
+ g_free (data);
}
}
@@ -519,7 +519,7 @@ gtd_manager__remove_task_finished (GObject *client,
result,
&error);
- gtd_object_set_ready (GTD_OBJECT (user_data), TRUE);
+ gtd_object_set_ready (GTD_OBJECT (data->data), TRUE);
/* Remove from 'Today' or 'Scheduled' as needed */
gtd_task_list_remove_task (priv->scheduled_tasks_list, (GtdTask*) data->data);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]