[gedit] Revert "view: do not depend on GSettings in show_line_numbers_menu()"



commit 2417e472fac1e89bd5c5e9a43dd108d57932e5e5
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Wed Jun 24 21:12:09 2015 +0200

    Revert "view: do not depend on GSettings in show_line_numbers_menu()"
    
    This reverts commit c8cbf12fa41f49ad815721328197c8702a2b29ec.
    
    The GtkSourceView property is set at other places in the code. E.g. for
    the statusbar setting which should only change the setting for the
    current document, not change the GSetting.

 gedit/gedit-view.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/gedit/gedit-view.c b/gedit/gedit-view.c
index 9ac9490..9ba45da 100644
--- a/gedit/gedit-view.c
+++ b/gedit/gedit-view.c
@@ -215,7 +215,7 @@ gedit_view_constructed (GObject *object)
                         GEDIT_SETTINGS_DISPLAY_LINE_NUMBERS,
                         view,
                         "show-line-numbers",
-                        G_SETTINGS_BIND_DEFAULT);
+                        G_SETTINGS_BIND_GET);
 
        g_settings_bind (priv->editor_settings,
                         GEDIT_SETTINGS_AUTO_INDENT,
@@ -521,9 +521,11 @@ show_line_numbers_menu (GeditView      *view,
        gtk_check_menu_item_set_active (GTK_CHECK_MENU_ITEM (item),
                                        gtk_source_view_get_show_line_numbers (GTK_SOURCE_VIEW (view)));
 
-       g_object_bind_property (item, "active",
-                               view, "show-line-numbers",
-                               G_BINDING_DEFAULT);
+       g_settings_bind (view->priv->editor_settings,
+                        GEDIT_SETTINGS_DISPLAY_LINE_NUMBERS,
+                        item,
+                        "active",
+                        G_SETTINGS_BIND_SET);
 
        gtk_menu_shell_append (GTK_MENU_SHELL (menu), item);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]