[gnumeric] Fix array size issue in Guppi plot parser. [#751383]



commit 92ce31e0fbced6284ab2bf7905b8af49aa18f3e9
Author: Jean Brefort <jean brefort normalesup org>
Date:   Wed Jun 24 08:22:13 2015 +0200

    Fix array size issue in Guppi plot parser. [#751383]

 ChangeLog                |    4 ++++
 NEWS                     |    3 ++-
 src/sheet-object-graph.c |    2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 9f3f757..cc02fcc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2015-06-24  Jean Brefort  <jean brefort normalesup org>
+
+       * src/sheet-object-graph.c (dim_start): fix index test. [#751383]
+
 2015-06-23  Jean Brefort  <jean brefort normalesup org>
 
        * src/xml-sax-read.c (gnm_xml_finish_obj), (xml_sax_read_obj),
diff --git a/NEWS b/NEWS
index 46f28ce..e0e65ec 100644
--- a/NEWS
+++ b/NEWS
@@ -14,7 +14,8 @@ Andreas:
 Jean:
        * Fix xlsx import of plot area manual layout. [#748016]
        * Fix out of bounds read. [#749121]
-       * Fuzzed file fixes.  [#750042] [751217] [#751270] [#751271]
+       * Fuzzed file fixes.  [#750042] [#751217] [#751270] [#751271]
+          [#751383]
 
 Morten:
        * Fix import/export of graph backplane.
diff --git a/src/sheet-object-graph.c b/src/sheet-object-graph.c
index 8d71be4..2c2e3b0 100644
--- a/src/sheet-object-graph.c
+++ b/src/sheet-object-graph.c
@@ -954,7 +954,7 @@ dim_start (GsfXMLIn *xin, xmlChar const **attrs)
                else if (0 == strcmp (attrs[i], "ID"))
                        id = strtoul (attrs[i+1], NULL, 10);
        if (!desc ||
-           id > state->data->len || g_ptr_array_index (state->data, id) == NULL)
+           id >= state->data->len || g_ptr_array_index (state->data, id) == NULL)
                return;
        if (0 == strcmp (name, "values"))
                type = GOG_MS_DIM_VALUES;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]