[gnome-software] Don't clear failed offline update results



commit 786999077324e4314c86a9f65683b24389ad6233
Author: Kalev Lember <klember redhat com>
Date:   Tue Jun 23 14:59:23 2015 +0200

    Don't clear failed offline update results
    
    Use the same logic here as when viewing a successful update and avoid
    unlinking the results file. We already have a guard in place that makes
    the error message show up only once for a user; unlinking it only makes
    it more difficult to access the error message at a later time through
    command line tools, such as 'pkcon offline-status'.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=91030

 src/gs-offline-updates.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
---
diff --git a/src/gs-offline-updates.c b/src/gs-offline-updates.c
index 6be4840..2ce438f 100644
--- a/src/gs-offline-updates.c
+++ b/src/gs-offline-updates.c
@@ -318,7 +318,6 @@ gs_offline_updates_show_error (GsShell *shell)
        const gchar *secondary;
        const gchar *geeky;
        GtkWidget *dialog;
-       _cleanup_error_free_ GError *error = NULL;
        _cleanup_object_unref_ PkError *pk_error = NULL;
        _cleanup_object_unref_ PkResults *results = NULL;
 
@@ -353,11 +352,6 @@ gs_offline_updates_show_error (GsShell *shell)
                                  G_CALLBACK (gtk_widget_destroy),
                                  dialog);
        gtk_widget_show (dialog);
-
-       if (!pk_offline_clear_results (NULL, &error)) {
-               g_warning ("Failure clearing offline update message: %s",
-                          error->message);
-       }
 }
 
 GPermission *


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]