[gnome-photos/wip/rishi/edit-mode: 1/30] gegl-gtk-view-helper: Don't redraw on every GeglNode::computed



commit d2f4589f7747265786aed0da4046235f63f8e8d4
Author: Debarshi Ray <debarshir gnome org>
Date:   Sun Jun 14 19:58:50 2015 +0200

    gegl-gtk-view-helper: Don't redraw on every GeglNode::computed
    
    GeglNode::computed is emitted after each chunk is processed. Drawing it
    chunk by chunk would create a visible checkerboard-like effect. To
    avoid it, PhotosPreviewView queues a draw after the entire GeglNode
    has been processed, so that the entire image can be drawn in one shot.
    
    There was a bug in GEGL which prevented GeglNode::computed from being
    emitted for graph nodes, so this was merely code that was not being
    used. Now that the bug has been fixed, we need to remove this code to
    prevent the checkerboard.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750938

 src/gegl-gtk-view-helper.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
---
diff --git a/src/gegl-gtk-view-helper.c b/src/gegl-gtk-view-helper.c
index 22bda9a..e7b4db4 100644
--- a/src/gegl-gtk-view-helper.c
+++ b/src/gegl-gtk-view-helper.c
@@ -223,15 +223,7 @@ computed_event(GeglNode      *node,
                GeglRectangle *rect,
                ViewHelper    *self)
 {
-    GeglRectangle redraw_rect;
-
     update_autoscale(self);
-
-    /* Emit redraw-needed */
-    redraw_rect = *rect;
-    model_rect_to_view_rect(self, &redraw_rect);
-
-    trigger_redraw(self, &redraw_rect);
 }
 
 ViewHelper *


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]