[gtk+] window: Avoid rising the window of already shown popovers



commit a0ff35f032643af888ff3bebe114d1f2968272c4
Author: Carlos Garnacho <carlosg gnome org>
Date:   Fri Jun 12 15:03:41 2015 +0200

    window: Avoid rising the window of already shown popovers
    
    This breaks stacking, as popovers are repositioned sort of frequently
    (even more after show/hide animations).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750741

 gtk/gtkwindow.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)
---
diff --git a/gtk/gtkwindow.c b/gtk/gtkwindow.c
index eea2a15..7f6f3e3 100644
--- a/gtk/gtkwindow.c
+++ b/gtk/gtkwindow.c
@@ -11905,15 +11905,10 @@ _gtk_window_set_popover_position (GtkWindow                   *window,
   data->rect = *rect;
   data->pos = pos;
 
-  if (gtk_widget_is_visible (popover))
+  if (gtk_widget_is_visible (popover) && !data->window)
     {
-      if (!data->window)
-        {
-          popover_realize (popover, data, window);
-          popover_map (popover, data);
-        }
-      else
-        gdk_window_raise (data->window);
+      popover_realize (popover, data, window);
+      popover_map (popover, data);
     }
 
   if (need_resize)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]