[gtk+/wip/matthiasc/touch-selection: 3/6] Don't popup after drag selection



commit 72c43b64ae84fcddddd50d7a6f9320d6dae92be1
Author: Matthias Clasen <mclasen redhat com>
Date:   Sun Jun 7 12:19:16 2015 -0400

    Don't popup after drag selection
    
    Don't show the touch selection popover after a selection drag
    ends. Instead, the popover will be triggered by an explicit
    touch on the selection.

 gtk/gtktextview.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)
---
diff --git a/gtk/gtktextview.c b/gtk/gtktextview.c
index 99ad656..9ca6d3b 100644
--- a/gtk/gtktextview.c
+++ b/gtk/gtktextview.c
@@ -7263,10 +7263,7 @@ gtk_text_view_drag_gesture_end (GtkGestureDrag *gesture,
 
   /* Check whether the drag was cancelled rather than finished */
   if (!gtk_gesture_handles_sequence (GTK_GESTURE (gesture), sequence))
-    {
-      gtk_text_view_selection_bubble_popup_unset (text_view);
-      return;
-    }
+    return;
 
   event = gtk_gesture_get_last_event (GTK_GESTURE (gesture), sequence);
   device = gdk_event_get_source_device (event);
@@ -7274,10 +7271,6 @@ gtk_text_view_drag_gesture_end (GtkGestureDrag *gesture,
     (gtk_get_debug_flags () & GTK_DEBUG_TOUCHSCREEN) != 0 ||
     gdk_device_get_source (device) == GDK_SOURCE_TOUCHSCREEN;
 
-  if (!clicked_in_selection && is_touchscreen &&
-      (!priv->selection_bubble || !gtk_widget_get_visible (priv->selection_bubble)))
-    gtk_text_view_selection_bubble_popup_set (text_view);
-
   if (!is_touchscreen && clicked_in_selection &&
       !gtk_drag_check_threshold (GTK_WIDGET (text_view), start_x, start_y, x, y))
     {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]